Re: Review Request 120877: Convert switch statements to if/else due to MSVC limitation

2015-04-03 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120877/ --- (Updated April 3, 2015, 7:30 p.m.) Status -- This change has been ma

Re: Review Request 120877: Convert switch statements to if/else due to MSVC limitation

2015-01-01 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120877/#review72855 --- Ship it! Unfortunate to replace the switch-case, but I don't

Re: Review Request 120877: Convert switch statements to if/else due to MSVC limitation

2014-10-29 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120877/ --- (Updated Out. 30, 2014, 1:35 a.m.) Review request for kdewin and Plasma.

Re: Review Request 120877: Convert switch statements to if/else due to MSVC limitation

2014-10-29 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120877/#review69384 --- No opinion on the patch but please check your coding style.

Review Request 120877: Convert switch statements to if/else due to MSVC limitation

2014-10-28 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120877/ --- Review request for kdewin and Plasma. Repository: plasma-framework Desc