Re: Review Request 120471: Add Registry::sync() signal

2014-10-14 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120471/ --- (Updated Oct. 14, 2014, 11:40 a.m.) Status -- This change has been m

Re: Review Request 120471: Add Registry::sync() signal

2014-10-13 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120471/#review68340 --- Ship it! looks good - Martin Gräßlin On Oct. 14, 2014, 4:1

Re: Review Request 120471: Add Registry::sync() signal

2014-10-13 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120471/ --- (Updated Oct. 14, 2014, 2:17 a.m.) Review request for kwin, Plasma and Ma

Re: Review Request 120471: Add Registry::sync() signal

2014-10-13 Thread Martin Gräßlin
> On Oct. 8, 2014, 9:46 a.m., Martin Gräßlin wrote: > > src/client/registry.cpp, line 119 > > > > > > this would crash - please use a test case for it. The destroy is > > intended to be used to clean up cleanly

Re: Review Request 120471: Add Registry::sync() signal

2014-10-08 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120471/#review68073 --- src/client/registry.cpp

Re: Review Request 120471: Add Registry::sync() signal

2014-10-07 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120471/ --- (Updated Oct. 7, 2014, 9:12 a.m.) Review request for kwin, Plasma and Mar

Re: Review Request 120471: Add Registry::sync() signal

2014-10-06 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120471/#review68034 --- src/client/registry.cpp

Re: Review Request 120471: Add Registry::sync() signal

2014-10-06 Thread Martin Gräßlin
> On Oct. 6, 2014, 12:25 p.m., Martin Gräßlin wrote: > > src/client/registry.h, line 407 > > > > > > I would recommend to move it to ConnectionThread as it's more > > connection related then registry related. >

Re: Review Request 120471: Add Registry::sync() signal

2014-10-06 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120471/ --- (Updated Oct. 7, 2014, 1:56 a.m.) Review request for kwin, Plasma and Mar

Re: Review Request 120471: Add Registry::sync() signal

2014-10-06 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120471/ --- (Updated Oct. 7, 2014, 1:37 a.m.) Review request for kwin, Plasma and Mar

Re: Review Request 120471: Add Registry::sync() signal

2014-10-06 Thread Sebastian Kügler
> On Oct. 6, 2014, 10:25 a.m., Martin Gräßlin wrote: > > src/client/registry.h, line 407 > > > > > > I would recommend to move it to ConnectionThread as it's more > > connection related then registry related. >

Re: Review Request 120471: Add Registry::sync() signal

2014-10-06 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120471/#review67980 --- src/client/registry.h

Review Request 120471: Add Registry::sync() signal

2014-10-02 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120471/ --- Review request for kwin, Plasma and Martin Gräßlin. Repository: kwayland