Re: Review Request 120087: Expose DurationFormatOption from KLocale

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120087/ --- (Updated Sept. 10, 2014, 8:53 a.m.) Status -- This change has been m

Re: Review Request 120087: Expose DurationFormatOption from KLocale

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120087/#review66127 --- Ship it! Ship It! - Marco Martin On Sept. 9, 2014, 1:56 p.

Re: Review Request 120087: Expose DurationFormatOption from KLocale

> On Sept. 9, 2014, 2:18 nachm., David Edmundson wrote: > > The Q_DECLARE should be in kformat? It is. See Review 120092 - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120087/

Re: Review Request 120087: Expose DurationFormatOption from KLocale

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120087/#review66125 --- The Q_DECLARE should be in kformat? - David Edmundson On Se

Re: Review Request 120087: Expose DurationFormatOption from KLocale

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120087/ --- (Updated Sept. 9, 2014, 1:56 nachm.) Review request for Plasma. Changes

Re: Review Request 120087: Expose DurationFormatOption from KLocale

> On Sept. 7, 2014, 1:53 p.m., David Edmundson wrote: > > src/qmlcontrols/kcoreaddons/formats.cpp, line 34 > > > > > > DurationFormatOption -> DurationFormatOptions ? > > > > as we want the flags not the

Re: Review Request 120087: Expose DurationFormatOption from KLocale

> On Sept. 7, 2014, 1:53 nachm., David Edmundson wrote: > > src/qmlcontrols/kcoreaddons/formats.cpp, line 34 > > > > > > DurationFormatOption -> DurationFormatOptions ? > > > > as we want the flags not th

Re: Review Request 120087: Expose DurationFormatOption from KLocale

> On Sept. 7, 2014, 9:52 a.m., David Edmundson wrote: > > src/qmlcontrols/kcoreaddons/formats.h, line 33 > > > > > > Rather than redeclaring the enum could we add Q_GADGET to kformat.h > > then export it to QML a

Re: Review Request 120087: Expose DurationFormatOption from KLocale

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120087/#review65989 --- src/qmlcontrols/kcoreaddons/formats.cpp

Re: Review Request 120087: Expose DurationFormatOption from KLocale

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120087/ --- (Updated Sept. 7, 2014, 1:24 nachm.) Review request for Plasma. Changes

Re: Review Request 120087: Expose DurationFormatOption from KLocale

> On Sept. 7, 2014, 9:52 a.m., David Edmundson wrote: > > src/qmlcontrols/kcoreaddons/formats.h, line 33 > > > > > > Rather than redeclaring the enum could we add Q_GADGET to kformat.h > > then export it to QML a

Re: Review Request 120087: Expose DurationFormatOption from KLocale

> On Sept. 7, 2014, 9:52 a.m., David Edmundson wrote: > > src/qmlcontrols/kcoreaddons/formats.h, line 33 > > > > > > Rather than redeclaring the enum could we add Q_GADGET to kformat.h > > then export it to QML a

Re: Review Request 120087: Expose DurationFormatOption from KLocale

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120087/#review65965 --- src/qmlcontrols/kcoreaddons/formats.h

Re: Review Request 120087: Expose DurationFormatOption from KLocale

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120087/#review65963 --- Ship it! src/qmlcontrols/kcoreaddons/formats.h

Review Request 120087: Expose DurationFormatOption from KLocale

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120087/ --- Review request for Plasma. Repository: kdeclarative Description ---