Re: Review Request 120036: Note loading in Notes Plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120036/ --- (Updated Sept. 15, 2014, 2:56 p.m.) Status -- This change has been m

Re: Review Request 120036: Note loading in Notes Plasmoid

> On Sept. 11, 2014, 1:17 p.m., Kai Uwe Broulik wrote: > > applets/notes/package/contents/ui/main.qml, line 88 > > > > > > I still think you should use NativeRendering aha, it's Text.NativeRendering. > On Sept.

Re: Review Request 120036: Note loading in Notes Plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120036/#review66248 --- Ship it! Some minor nitpicks below. Thanks! applets/notes/p

Re: Review Request 120036: Note loading in Notes Plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120036/ --- (Updated Sept. 7, 2014, 3:07 p.m.) Review request for Plasma. Repositor

Re: Review Request 120036: Note loading in Notes Plasmoid

> On Sept. 2, 2014, 11:59 a.m., Marco Martin wrote: > > applets/notes/plugin/filesystemnoteloader.cpp, line 39 > > > > > > I wonder if wasn't prettier/more efficient if Note and NoteManager > > instances were act

Re: Review Request 120036: Note loading in Notes Plasmoid

> On Sept. 2, 2014, 11:59 a.m., Marco Martin wrote: > > First of all, I'm fine with this approach if this gets chosen, all matters > > is that end up working reliably and depends from the exact use case. > > > > That said, what did strike to me, is that the problem that seems to be > > solved

Re: Review Request 120036: Note loading in Notes Plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120036/#review65706 --- First of all, I'm fine with this approach if this gets chosen,

Re: Review Request 120036: Note loading in Notes Plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120036/#review65709 --- Looking good :) applets/notes/package/contents/ui/main.qml <

Re: Review Request 120036: Note loading in Notes Plasmoid

> On Sept. 2, 2014, 11:20 a.m., Sebastian Kügler wrote: > > I don't fully understand how the "write to a different property" mechanism > > works. Could you expand on that? > > > > The code overall looks quite good already, but without understanding the > > above, I don't dare giving it a shipi

Re: Review Request 120036: Note loading in Notes Plasmoid

> On Sept. 2, 2014, 11:20 a.m., Sebastian Kügler wrote: > > I don't fully understand how the "write to a different property" mechanism > > works. Could you expand on that? > > > > The code overall looks quite good already, but without understanding the > > above, I don't dare giving it a shipi

Re: Review Request 120036: Note loading in Notes Plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120036/#review65704 --- I don't fully understand how the "write to a different propert

Re: Review Request 120036: Note loading in Notes Plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120036/#review65703 --- applets/notes/plugin/notemanager.cpp

Review Request 120036: Note loading in Notes Plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120036/ --- Review request for Plasma. Repository: kdeplasma-addons Description ---