Re: Review Request 119988: Package structure cleanups

2014-08-29 Thread Marco Martin
> On Aug. 29, 2014, noon, David Edmundson wrote: > > src/plasma/packagestructure.h, line 99 > > > > > > would removing a #define count as a SIC? > > Aaron J. Seigo wrote: > Yes, but I don't think it maters fo

Re: Review Request 119988: Package structure cleanups

2014-08-29 Thread David Edmundson
> On Aug. 29, 2014, noon, David Edmundson wrote: > > src/plasma/packagestructure.h, line 99 > > > > > > would removing a #define count as a SIC? > > Aaron J. Seigo wrote: > Yes, but I don't think it maters fo

Re: Review Request 119988: Package structure cleanups

2014-08-29 Thread Marco Martin
> On Aug. 29, 2014, noon, David Edmundson wrote: > > src/plasma/packagestructure.h, line 99 > > > > > > would removing a #define count as a SIC? > > Aaron J. Seigo wrote: > Yes, but I don't think it maters fo

Re: Review Request 119988: Package structure cleanups

2014-08-29 Thread David Edmundson
> On Aug. 29, 2014, noon, David Edmundson wrote: > > src/plasma/packagestructure.h, line 99 > > > > > > would removing a #define count as a SIC? > > Aaron J. Seigo wrote: > Yes, but I don't think it maters fo

Re: Review Request 119988: Package structure cleanups

2014-08-29 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119988/ --- (Updated Aug. 29, 2014, 2:20 p.m.) Status -- This change has been di

Re: Review Request 119988: Package structure cleanups

2014-08-29 Thread Aaron J. Seigo
> On Aug. 29, 2014, noon, David Edmundson wrote: > > src/plasma/packagestructure.h, line 99 > > > > > > would removing a #define count as a SIC? > > Aaron J. Seigo wrote: > Yes, but I don't think it maters fo

Re: Review Request 119988: Package structure cleanups

2014-08-29 Thread Marco Martin
> On Aug. 29, 2014, noon, David Edmundson wrote: > > src/plasma/packagestructure.h, line 99 > > > > > > would removing a #define count as a SIC? > > Aaron J. Seigo wrote: > Yes, but I don't think it maters fo

Re: Review Request 119988: Package structure cleanups

2014-08-29 Thread Aaron J. Seigo
> On Aug. 29, 2014, noon, David Edmundson wrote: > > src/plasma/packagestructure.h, line 99 > > > > > > would removing a #define count as a SIC? > > Aaron J. Seigo wrote: > Yes, but I don't think it maters fo

Re: Review Request 119988: Package structure cleanups

2014-08-29 Thread Aaron J. Seigo
> On Aug. 29, 2014, noon, David Edmundson wrote: > > src/plasma/packagestructure.h, line 99 > > > > > > would removing a #define count as a SIC? > > Aaron J. Seigo wrote: > Yes, but I don't think it maters fo

Re: Review Request 119988: Package structure cleanups

2014-08-29 Thread Martin Gräßlin
> On Aug. 29, 2014, 2 p.m., David Edmundson wrote: > > src/plasma/packagestructure.h, line 99 > > > > > > would removing a #define count as a SIC? > > Aaron J. Seigo wrote: > Yes, but I don't think it maters

Re: Review Request 119988: Package structure cleanups

2014-08-29 Thread David Edmundson
> On Aug. 29, 2014, noon, David Edmundson wrote: > > src/plasma/packagestructure.h, line 99 > > > > > > would removing a #define count as a SIC? > > Aaron J. Seigo wrote: > Yes, but I don't think it maters fo

Re: Review Request 119988: Package structure cleanups

2014-08-29 Thread Hrvoje Senjan
> On Aug. 29, 2014, 2 p.m., David Edmundson wrote: > > src/plasma/packagestructure.h, line 99 > > > > > > would removing a #define count as a SIC? > > Aaron J. Seigo wrote: > Yes, but I don't think it maters

Re: Review Request 119988: Package structure cleanups

2014-08-29 Thread Aaron J. Seigo
> On Aug. 29, 2014, noon, David Edmundson wrote: > > src/plasma/packagestructure.h, line 99 > > > > > > would removing a #define count as a SIC? Yes, but I don't think it maters for two reasons: 1) DataEngine al

Re: Review Request 119988: Package structure cleanups

2014-08-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119988/#review65482 --- Ship it! +1 for removing shellpackage. good for plugin-ificat

Re: Review Request 119988: Package structure cleanups

2014-08-29 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119988/#review65481 --- src/plasma/packagestructure.h

Review Request 119988: Package structure cleanups

2014-08-29 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119988/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor