Re: Review Request 119974: port Slider to QtControls

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119974/ --- (Updated Aug. 28, 2014, 2:17 p.m.) Status -- This change has been ma

Re: Review Request 119974: port Slider to QtControls

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119974/ --- (Updated Aug. 28, 2014, 2:14 p.m.) Review request for Plasma. Repositor

Re: Review Request 119974: port Slider to QtControls

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119974/#review65440 --- Ship it! src/declarativeimports/plasmacomponents/qml/Slider.

Re: Review Request 119974: port Slider to QtControls

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119974/ --- (Updated Aug. 28, 2014, 2:09 p.m.) Review request for Plasma. Repositor

Re: Review Request 119974: port Slider to QtControls

> On Aug. 28, 2014, 1:46 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/SliderStyle.qml, line 35 > > > > > > in the last review we explicilty set panel to Item {} > > > >

Re: Review Request 119974: port Slider to QtControls

> On Aug. 28, 2014, 1:31 p.m., Kai Uwe Broulik wrote: > > src/declarativeimports/plasmacomponents/qml/Slider.qml, lines 125-126 > > > > > > Is that still needed? > > Marco Martin wrote: > I don't know, but t

Re: Review Request 119974: port Slider to QtControls

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119974/#review65431 --- src/declarativeimports/plasmacomponents/qml/Slider.qml

Re: Review Request 119974: port Slider to QtControls

> On Aug. 28, 2014, 1:31 p.m., Kai Uwe Broulik wrote: > > src/declarativeimports/plasmacomponents/qml/Slider.qml, lines 125-126 > > > > > > Is that still needed? I don't know, but the base component doesn't have

Re: Review Request 119974: port Slider to QtControls

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119974/#review65430 --- src/declarativeimports/plasmacomponents/qml/Slider.qml

Review Request 119974: port Slider to QtControls

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119974/ --- Review request for Plasma. Summary (updated) - port Slid