Re: Review Request 119523: port TextField to QtControls

2014-08-07 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119523/ --- (Updated Aug. 7, 2014, 1:45 p.m.) Status -- This change has been mar

Re: Review Request 119523: port TextField to QtControls

2014-08-04 Thread David Edmundson
On July 28, 2014, 6:54 p.m., Marco Martin wrote: > > Which methods do we need the inner control for? I saw positionAtPos and > > positionToRectangle, any others? > > Marco Martin wrote: > those two and passwordCharacter > > David Edmundson wrote: > and missing properties are: > >

Re: Review Request 119523: port TextField to QtControls

2014-07-31 Thread Marco Martin
On July 28, 2014, 6:54 p.m., Marco Martin wrote: > > Which methods do we need the inner control for? I saw positionAtPos and > > positionToRectangle, any others? > > Marco Martin wrote: > those two and passwordCharacter > > David Edmundson wrote: > and missing properties are: > >

Re: Review Request 119523: port TextField to QtControls

2014-07-31 Thread David Edmundson
On July 28, 2014, 6:54 p.m., Marco Martin wrote: > > Which methods do we need the inner control for? I saw positionAtPos and > > positionToRectangle, any others? > > Marco Martin wrote: > those two and passwordCharacter > > David Edmundson wrote: > and missing properties are: > >

Re: Review Request 119523: port TextField to QtControls

2014-07-28 Thread David Edmundson
> On July 28, 2014, 6:54 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/TextField.qml, line 366 > > > > > > This is going to overlap with the text I think. > > It might be worth

Re: Review Request 119523: port TextField to QtControls

2014-07-28 Thread Marco Martin
> On July 28, 2014, 7:09 p.m., Kai Uwe Broulik wrote: > > src/declarativeimports/plasmacomponents/qml/styles/TextFieldStyle.qml, line > > 52 > > > > > > Can't you account for the clear button width here? probabl

Re: Review Request 119523: port TextField to QtControls

2014-07-28 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119523/#review63367 --- src/declarativeimports/plasmacomponents/qml/styles/TextFieldS

Re: Review Request 119523: port TextField to QtControls

2014-07-28 Thread David Edmundson
On July 28, 2014, 6:54 p.m., Marco Martin wrote: > > Which methods do we need the inner control for? I saw positionAtPos and > > positionToRectangle, any others? > > Marco Martin wrote: > those two and passwordCharacter and missing properties are: passwordCharacter errorHighlight - Davi

Re: Review Request 119523: port TextField to QtControls

2014-07-28 Thread Marco Martin
> On July 28, 2014, 6:54 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/TextField.qml, line 366 > > > > > > This is going to overlap with the text I think. > > It might be worth

Re: Review Request 119523: port TextField to QtControls

2014-07-28 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119523/#review63363 --- Even if we fix the methods it's too close to 5.1 to merge righ

Review Request 119523: port TextField to QtControls

2014-07-28 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119523/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor