Re: Review Request 119455: make Button a QtControl

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119455/#review63163 --- One thing tough, i would put back in all the documentation com

Re: Review Request 119455: make Button a QtControl

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119455/ --- (Updated July 25, 2014, 11:05 a.m.) Status -- This change has been m

Re: Review Request 119455: make Button a QtControl

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119455/#review63130 --- Ship it! Ship It! - David Edmundson On July 25, 2014, 10:5

Re: Review Request 119455: make Button a QtControl

> On July 25, 2014, 10:44 a.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml, line 76 > > > > > > This causes a behavioural change: > > > > look at line 10

Re: Review Request 119455: make Button a QtControl

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119455/ --- (Updated July 25, 2014, 10:55 a.m.) Review request for KDE Frameworks and

Re: Review Request 119455: make Button a QtControl

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119455/#review63127 --- src/declarativeimports/plasmacomponents/qml/styles/ButtonStyl

Re: Review Request 119455: make Button a QtControl

> On July 25, 2014, 8:13 a.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml, line 42 > > > > > > I was thinking this can become just > > > > property real

Re: Review Request 119455: make Button a QtControl

> On July 25, 2014, 8:13 a.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml, line 42 > > > > > > I was thinking this can become just > > > > property real

Re: Review Request 119455: make Button a QtControl

> On July 25, 2014, 8:13 a.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml, line 42 > > > > > > I was thinking this can become just > > > > property real

Re: Review Request 119455: make Button a QtControl

> On July 25, 2014, 8:13 a.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml, line 42 > > > > > > I was thinking this can become just > > > > property real

Re: Review Request 119455: make Button a QtControl

> On July 25, 2014, 8:13 a.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml, line 42 > > > > > > I was thinking this can become just > > > > property real

Re: Review Request 119455: make Button a QtControl

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119455/ --- (Updated July 25, 2014, 9:41 a.m.) Review request for KDE Frameworks and

Re: Review Request 119455: make Button a QtControl

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119455/#review63110 --- I think this is nearly good to go. A few questions below. sr

Re: Review Request 119455: make Button a QtControl

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119455/ --- (Updated July 24, 2014, 6:17 p.m.) Review request for KDE Frameworks and

Re: Review Request 119455: make Button a QtControl

> On July 24, 2014, 4:56 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml, line 83 > > > > > > style.labelImplicitWidth doesn't exist? gah, leftover - Marco

Re: Review Request 119455: make Button a QtControl

> On July 24, 2014, 4:56 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml, line 41 > > > > > > This isn't very declarative, is there a reason we can't do: > >

Re: Review Request 119455: make Button a QtControl

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119455/#review63091 --- src/declarativeimports/plasmacomponents/qml/styles/ButtonStyl

Re: Review Request 119455: make Button a QtControl

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119455/ --- (Updated July 24, 2014, 4:31 p.m.) Review request for KDE Frameworks and

Re: Review Request 119455: make Button a QtControl

> On July 24, 2014, 4:20 p.m., Martin Gräßlin wrote: > > Concerning the icon names: for the Desktops Effects KCM the names are > > working without me doing anything. So there must be a solution hidden in > > the widgets emulating style. yes, the native style figures out that internally, create

Re: Review Request 119455: make Button a QtControl

> On July 24, 2014, 4:18 p.m., Andrew Lake wrote: > > Exciting! > > > > Might this eventually support a ButtonStyle.qml in the plasma theme that > > overrides the svg-based ButtonStyle if it's present? That way we could take > > the already developed Breeze ButtonStyle.qml and just ship it in

Re: Review Request 119455: make Button a QtControl

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119455/#review63087 --- Concerning the icon names: for the Desktops Effects KCM the na

Re: Review Request 119455: make Button a QtControl

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119455/#review63086 --- Exciting! Might this eventually support a ButtonStyle.qml in

Review Request 119455: make Button a QtControl

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119455/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor