Re: Review Request 119425: Cache the textures created for the fast path

> On July 25, 2014, 1:55 p.m., Marco Martin wrote: > > To me, at least on Nvidia seems that graphics gets completely broken for > > popup contents. > > > > I think it should watch for widow change and delete the cache/rebuild the > > textures in that case > > Aleix Pol Gonzalez wrote: > D

Re: Review Request 119425: Cache the textures created for the fast path

> On July 25, 2014, 1:55 p.m., Marco Martin wrote: > > To me, at least on Nvidia seems that graphics gets completely broken for > > popup contents. > > > > I think it should watch for widow change and delete the cache/rebuild the > > textures in that case > > Aleix Pol Gonzalez wrote: > D

Re: Review Request 119425: Cache the textures created for the fast path

> On July 25, 2014, 1:55 p.m., Marco Martin wrote: > > To me, at least on Nvidia seems that graphics gets completely broken for > > popup contents. > > > > I think it should watch for widow change and delete the cache/rebuild the > > textures in that case > > Aleix Pol Gonzalez wrote: > D

Re: Review Request 119425: Cache the textures created for the fast path

> On July 25, 2014, 1:55 p.m., Marco Martin wrote: > > To me, at least on Nvidia seems that graphics gets completely broken for > > popup contents. > > > > I think it should watch for widow change and delete the cache/rebuild the > > textures in that case > > Aleix Pol Gonzalez wrote: > D

Re: Review Request 119425: Cache the textures created for the fast path

> On July 25, 2014, 1:55 p.m., Marco Martin wrote: > > To me, at least on Nvidia seems that graphics gets completely broken for > > popup contents. > > > > I think it should watch for widow change and delete the cache/rebuild the > > textures in that case > > Aleix Pol Gonzalez wrote: > D

Re: Review Request 119425: Cache the textures created for the fast path

> On July 25, 2014, 1:55 p.m., Marco Martin wrote: > > To me, at least on Nvidia seems that graphics gets completely broken for > > popup contents. > > > > I think it should watch for widow change and delete the cache/rebuild the > > textures in that case Do you have a picture? Here (intel)

Re: Review Request 119425: Cache the textures created for the fast path

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119425/#review63152 --- To me, at least on Nvidia seems that graphics gets completely

Re: Review Request 119425: Cache the textures created for the fast path

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119425/ --- (Updated July 25, 2014, 10:57 a.m.) Status -- This change has been m

Re: Review Request 119425: Cache the textures created for the fast path

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119425/#review63128 --- Ship it! Ship It! - Marco Martin On July 25, 2014, 10:14 a

Re: Review Request 119425: Cache the textures created for the fast path

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119425/#review63124 --- Ship it! src/declarativeimports/core/framesvgitem.cpp

Re: Review Request 119425: Cache the textures created for the fast path

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119425/ --- (Updated July 25, 2014, 10:14 a.m.) Review request for Plasma. Changes

Re: Review Request 119425: Cache the textures created for the fast path

> On July 24, 2014, 10:55 a.m., David Edmundson wrote: > > src/declarativeimports/core/framesvgitem.cpp, line 45 > > > > > > Having spoken to you offline this does make sense, but it needs > > documentation as to

Re: Review Request 119425: Cache the textures created for the fast path

> On July 24, 2014, 10:55 a.m., David Edmundson wrote: > > src/declarativeimports/core/framesvgitem.cpp, line 45 > > > > > > Having spoken to you offline this does make sense, but it needs > > documentation as to

Re: Review Request 119425: Cache the textures created for the fast path

> On July 24, 2014, 10:55 a.m., David Edmundson wrote: > > src/declarativeimports/core/framesvgitem.cpp, line 45 > > > > > > Having spoken to you offline this does make sense, but it needs > > documentation as to

Re: Review Request 119425: Cache the textures created for the fast path

> On July 24, 2014, 10:55 a.m., David Edmundson wrote: > > src/declarativeimports/core/framesvgitem.cpp, line 45 > > > > > > Having spoken to you offline this does make sense, but it needs > > documentation as to

Re: Review Request 119425: Cache the textures created for the fast path

> On July 24, 2014, 10:55 a.m., David Edmundson wrote: > > src/declarativeimports/core/framesvgitem.cpp, line 45 > > > > > > Having spoken to you offline this does make sense, but it needs > > documentation as to

Re: Review Request 119425: Cache the textures created for the fast path

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119425/ --- (Updated July 24, 2014, 11:14 a.m.) Review request for Plasma. Changes

Re: Review Request 119425: Cache the textures created for the fast path

> On July 24, 2014, 10:55 a.m., David Edmundson wrote: > > src/declarativeimports/core/framesvgitem.cpp, line 45 > > > > > > Having spoken to you offline this does make sense, but it needs > > documentation as to

Re: Review Request 119425: Cache the textures created for the fast path

> On July 24, 2014, 10:55 a.m., David Edmundson wrote: > > src/declarativeimports/core/framesvgitem.cpp, line 45 > > > > > > Having spoken to you offline this does make sense, but it needs > > documentation as to

Re: Review Request 119425: Cache the textures created for the fast path

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119425/#review63049 --- src/declarativeimports/core/framesvgitem.cpp

Re: Review Request 119425: Cache the textures created for the fast path

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119425/ --- (Updated July 24, 2014, 12:44 a.m.) Review request for Plasma. Changes

Re: Review Request 119425: Cache the textures created for the fast path

> On July 23, 2014, 2:38 p.m., David Edmundson wrote: > > src/declarativeimports/core/framesvgitem.cpp, line 391 > > > > > > this means every object performs a method on a singleton. > > > > Arguably fol

Re: Review Request 119425: Cache the textures created for the fast path

> On July 23, 2014, 2:38 p.m., David Edmundson wrote: > > src/declarativeimports/core/framesvgitem.cpp, line 391 > > > > > > this means every object performs a method on a singleton. > > > > Arguably fol

Re: Review Request 119425: Cache the textures created for the fast path

> On July 23, 2014, 2:38 p.m., David Edmundson wrote: > > src/declarativeimports/core/framesvgitem.cpp, line 391 > > > > > > this means every object performs a method on a singleton. > > > > Arguably fol

Re: Review Request 119425: Cache the textures created for the fast path

> On July 23, 2014, 2:38 p.m., David Edmundson wrote: > > src/declarativeimports/core/framesvgitem.cpp, line 391 > > > > > > this means every object performs a method on a singleton. > > > > Arguably fol

Re: Review Request 119425: Cache the textures created for the fast path

> On July 23, 2014, 2:38 p.m., David Edmundson wrote: > > src/declarativeimports/core/framesvgitem.cpp, line 391 > > > > > > this means every object performs a method on a singleton. > > > > Arguably fol

Re: Review Request 119425: Cache the textures created for the fast path

> On July 23, 2014, 2:38 p.m., David Edmundson wrote: > > src/declarativeimports/core/framesvgitem.cpp, line 391 > > > > > > this means every object performs a method on a singleton. > > > > Arguably fol

Re: Review Request 119425: Cache the textures created for the fast path

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119425/#review62973 --- Ignore the marking as submitted. I had two reviewboard tabs op

Re: Review Request 119425: Cache the textures created for the fast path

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119425/ --- (Updated July 23, 2014, 3:35 p.m.) Status -- This change has been ma

Re: Review Request 119425: Cache the textures created for the fast path

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119425/#review62967 --- src/declarativeimports/core/framesvgitem.cpp

Review Request 119425: Cache the textures created for the fast path

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119425/ --- Review request for Plasma. Repository: plasma-framework Description ---