Re: Review Request 119355: Change use of MacroPushRequiredVars to CMakePushCheckState

2014-07-18 Thread Tobias Berner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119355/ --- (Updated July 18, 2014, 8:55 p.m.) Status -- This change has been ma

Re: Review Request 119355: Change use of MacroPushRequiredVars to CMakePushCheckState

2014-07-18 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119355/#review62654 --- Ship it! Ship It! - Aleix Pol Gonzalez On July 18, 2014, 1

Re: Review Request 119355: Change use of MacroPushRequiredVars to CMakePushCheckState

2014-07-18 Thread Raphael Kubo da Costa
> On July 18, 2014, 2:57 p.m., Aleix Pol Gonzalez wrote: > > Is it available in 2.8.13? Otherwise we'd have to bump the dependency > > requirement to 3.0. It's actually been available since 2.8.6: http://cmake.org/gitweb?p=cmake.git;a=commit;h=1325260a664577a1356f3034ed5f110d45f6a6d8 - Rapha

Re: Review Request 119355: Change use of MacroPushRequiredVars to CMakePushCheckState

2014-07-18 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119355/#review62649 --- Is it available in 2.8.13? Otherwise we'd have to bump the dep

Review Request 119355: Change use of MacroPushRequiredVars to CMakePushCheckState

2014-07-18 Thread Tobias Berner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119355/ --- Review request for Plasma and Raphael Kubo da Costa. Repository: plasma-w