Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119336/ --- (Updated July 29, 2014, 9:10 a.m.) Status -- This change has been di

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119336/#review63396 --- Is this still useful? - David Edmundson On July 17, 2014, 8

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119336/#review62657 --- src/declarativeimports/core/framesvgitem.cpp

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

> On July 18, 2014, 10:54 a.m., David Edmundson wrote: > > src/declarativeimports/core/framesvgitem.cpp, line 121 > > > > > > 1) This leaks. > > if you remove a node from a parent you have to delete it yourse

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119336/#review62619 --- src/declarativeimports/core/framesvgitem.cpp

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119336/ --- (Updated July 17, 2014, 8:17 p.m.) Review request for KDE Frameworks and

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

> On July 17, 2014, 4:54 p.m., Eike Hein wrote: > > Unless I'm missing something, this approach seems to defeat the purpose of > > the exercise: The goal of the original change is to use actually use > > smaller textures that fit the QSG's "this can use the atlas" heuristic on > > most platfor

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

> On July 17, 2014, 4:54 p.m., Eike Hein wrote: > > Unless I'm missing something, this approach seems to defeat the purpose of > > the exercise: The goal of the original change is to use actually use > > smaller textures that fit the QSG's "this can use the atlas" heuristic on > > most platfor

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

> On July 17, 2014, 4:54 p.m., Eike Hein wrote: > > Unless I'm missing something, this approach seems to defeat the purpose of > > the exercise: The goal of the original change is to use actually use > > smaller textures that fit the QSG's "this can use the atlas" heuristic on > > most platfor

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

> On July 17, 2014, 4:54 p.m., Eike Hein wrote: > > Unless I'm missing something, this approach seems to defeat the purpose of > > the exercise: The goal of the original change is to use actually use > > smaller textures that fit the QSG's "this can use the atlas" heuristic on > > most platfor

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

> On July 17, 2014, 4:54 p.m., Eike Hein wrote: > > Unless I'm missing something, this approach seems to defeat the purpose of > > the exercise: The goal of the original change is to use actually use > > smaller textures that fit the QSG's "this can use the atlas" heuristic on > > most platfor

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

> On July 17, 2014, 4:54 p.m., Eike Hein wrote: > > Unless I'm missing something, this approach seems to defeat the purpose of > > the exercise: The goal of the original change is to use actually use > > smaller textures that fit the QSG's "this can use the atlas" heuristic on > > most platfor

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119336/#review62607 --- Unless I'm missing something, this approach seems to defeat th

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

> On July 17, 2014, 1:42 p.m., David Edmundson wrote: > > src/declarativeimports/core/framesvgitem.cpp, line 434 > > > > > > How is this whole branch "simpler" ? > > > > We end up doing widths and sizes

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

> On July 17, 2014, 1:42 p.m., David Edmundson wrote: > > src/declarativeimports/core/framesvgitem.cpp, line 204 > > > > > > Just no. to me, or that or stays as is in master now. Again, the timer can be disabled

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

> On July 17, 2014, 1:42 p.m., David Edmundson wrote: > > src/declarativeimports/core/framesvgitem.cpp, line 434 > > > > > > How is this whole branch "simpler" ? > > > > We end up doing widths and sizes

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

> On July 17, 2014, 1:42 p.m., David Edmundson wrote: > > src/declarativeimports/core/framesvgitem.cpp, line 434 > > > > > > How is this whole branch "simpler" ? > > > > We end up doing widths and sizes

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

> On July 17, 2014, 1:42 p.m., David Edmundson wrote: > > >the important differences are two, that are imo 100% necessary to maintain > > >a pixel perfect rendering (sacrificing that is a regression simply not > > >acceptable in any case, even for non default themes, ever). At the same > > >ti

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119336/#review62575 --- >the important differences are two, that are imo 100% necessar

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119336/ --- (Updated July 17, 2014, 12:47 p.m.) Review request for KDE Frameworks and

Review Request 119336: Convert FrameSvg to 9 textures: different approach

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119336/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119336/ --- (Updated July 17, 2014, 12:13 p.m.) Review request for KDE Frameworks and