Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/ --- (Updated July 6, 2014, 2:41 p.m.) Status -- This change has been mar

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/#review61724 --- Ship it! You can push it after the two fixes below. startkd

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/ --- (Updated Lug. 6, 2014, 1:46 p.m.) Review request for KDE Frameworks, Plas

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/ --- (Updated Lug. 6, 2014, 1:44 p.m.) Review request for KDE Frameworks, Plas

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

> On Lug. 6, 2014, 1:25 p.m., David Faure wrote: > > I added GenericConfigLocation to Qt 5.2.0's QStandardPaths, but indeed it's > > missing in qtpaths, I'll fix that. > > > > We should be using it, because ConfigLocation includes the appname on > > Windows (big whoops). > > David Faure wrote

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/#review61708 --- startkde/startkde.cmake

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

> On July 6, 2014, 1:25 p.m., David Faure wrote: > > I added GenericConfigLocation to Qt 5.2.0's QStandardPaths, but indeed it's > > missing in qtpaths, I'll fix that. > > > > We should be using it, because ConfigLocation includes the appname on > > Windows (big whoops). > > David Faure wrote

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/ --- (Updated Lug. 6, 2014, 1:35 p.m.) Review request for KDE Frameworks, Plas

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

> On Lug. 6, 2014, 1:25 p.m., David Faure wrote: > > I added GenericConfigLocation to Qt 5.2.0's QStandardPaths, but indeed it's > > missing in qtpaths, I'll fix that. > > > > We should be using it, because ConfigLocation includes the appname on > > Windows (big whoops). > > David Faure wrote

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

> On July 6, 2014, 1:25 p.m., David Faure wrote: > > I added GenericConfigLocation to Qt 5.2.0's QStandardPaths, but indeed it's > > missing in qtpaths, I'll fix that. > > > > We should be using it, because ConfigLocation includes the appname on > > Windows (big whoops). I mean we should be u

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/#review61701 --- I added GenericConfigLocation to Qt 5.2.0's QStandardPaths, bu

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/ --- (Updated Lug. 6, 2014, 1:19 p.m.) Review request for KDE Frameworks, Plas

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/ --- (Updated Lug. 6, 2014, 1:13 p.m.) Review request for KDE Frameworks, Plas

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

> On Lug. 6, 2014, 12:57 p.m., David Faure wrote: > > GenericDataLocation + env is polluting the global namespace. Imagine if > > gnome did the same... > > > > My suggestion is GenericConfigLocation + "/startkde/env/" > > or GenericConfigLocation + "/kde-workspace/env/". > > > > Yes, this mean

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/#review61694 --- GenericDataLocation + env is polluting the global namespace. I

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/ --- (Updated Lug. 6, 2014, 12:52 p.m.) Review request for KDE Frameworks, Pla

Review Request 119145: Use qtpaths instead of kf5-confg in startkde

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/ --- Review request for KDE Frameworks, Plasma and David Faure. Bugs: 333793