Re: Review Request 118730: [startkde] Introduce a ksyncdbusenv helper application

> On June 14, 2014, 9:12 p.m., Hrvoje Senjan wrote: > > startkde/ksyncdbusenv/CMakeLists.txt, line 5 > > > > > > it was my understanding that KF5_LIBEXEC_INSTALL_DIR is 'reserved' for > > KF5, and rest of dependin

Re: Review Request 118730: [startkde] Introduce a ksyncdbusenv helper application

> On June 14, 2014, 9:12 p.m., Hrvoje Senjan wrote: > > startkde/ksyncdbusenv/CMakeLists.txt, line 5 > > > > > > it was my understanding that KF5_LIBEXEC_INSTALL_DIR is 'reserved' for > > KF5, and rest of dependin

Re: Review Request 118730: [startkde] Introduce a ksyncdbusenv helper application

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118730/#review60095 --- startkde/ksyncdbusenv/CMakeLists.txt

Re: Review Request 118730: [startkde] Introduce a ksyncdbusenv helper application

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118730/ --- (Updated June 14, 2014, 8:41 a.m.) Status -- This change has been ma

Re: Review Request 118730: [startkde] Introduce a ksyncdbusenv helper application

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118730/#review60066 --- This review has been submitted with commit b551c6dbd4490b04a0

Re: Review Request 118730: [startkde] Introduce a ksyncdbusenv helper application

> On June 13, 2014, 9:46 p.m., David Edmundson wrote: > > startkde/ksyncdbusenv/ksyncdbusenv.cpp, line 48 > > > > > > if we do .asyncCall() and waitForFinished() > > > > we may as well just do .call() > >

Re: Review Request 118730: [startkde] Introduce a ksyncdbusenv helper application

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118730/#review60042 --- Ship it! startkde/ksyncdbusenv/ksyncdbusenv.cpp

Re: Review Request 118730: [startkde] Introduce a ksyncdbusenv helper application

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118730/ --- (Updated June 13, 2014, 9:36 p.m.) Review request for Plasma and David Ed

Re: Review Request 118730: [startkde] Introduce a ksyncdbusenv helper application

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118730/#review60041 --- startkde/startkde.cmake

Re: Review Request 118730: [startkde] Introduce a ksyncdbusenv helper application

> On June 13, 2014, 3:14 p.m., David Edmundson wrote: > > I don't understand where this is useful unless you have a broken setup to > > begin with. > > > > Either you have your XDG paths set up properly for all users at which point > > you don't need this. > > Or you have DBus setup to load ap

Re: Review Request 118730: [startkde] Introduce a ksyncdbusenv helper application

> On June 13, 2014, 3:14 p.m., David Edmundson wrote: > > I don't understand where this is useful unless you have a broken setup to > > begin with. > > > > Either you have your XDG paths set up properly for all users at which point > > you don't need this. > > Or you have DBus setup to load ap

Re: Review Request 118730: [startkde] Introduce a ksyncdbusenv helper application

> On June 13, 2014, 1:14 p.m., David Edmundson wrote: > > I don't understand where this is useful unless you have a broken setup to > > begin with. > > > > Either you have your XDG paths set up properly for all users at which point > > you don't need this. > > Or you have DBus setup to load ap

Re: Review Request 118730: [startkde] Introduce a ksyncdbusenv helper application

> On June 13, 2014, 3:25 p.m., David Edmundson wrote: > > startkde/ksyncdbusenv/ksyncdbusenv.cpp, line 38 > > > > > > for (auto i = map.constBegin(); i != map.constEnd(); ++i) > > env.insert(i.key(), i.val

Re: Review Request 118730: [startkde] Introduce a ksyncdbusenv helper application

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118730/#review59985 --- startkde/ksyncdbusenv/ksyncdbusenv.cpp

Re: Review Request 118730: [startkde] Introduce a ksyncdbusenv helper application

> On June 13, 2014, 3:14 p.m., David Edmundson wrote: > > I don't understand where this is useful unless you have a broken setup to > > begin with. > > > > Either you have your XDG paths set up properly for all users at which point > > you don't need this. > > Or you have DBus setup to load ap

Re: Review Request 118730: [startkde] Introduce a ksyncdbusenv helper application

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118730/#review59979 --- I don't understand where this is useful unless you have a brok

Review Request 118730: [startkde] Introduce a ksyncdbusenv helper application

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118730/ --- Review request for Plasma and David Edmundson. Repository: plasma-workspa