Re: Review Request 118290: Streamline Comment fields of KCMs

2014-05-29 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118290/ --- (Updated May 29, 2014, 11:28 p.m.) Status -- This change has been ma

Re: Review Request 118290: Streamline Comment fields of KCMs

2014-05-29 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118290/#review58763 --- This review has been submitted with commit 7128a3aca1cbc1397b

Re: Review Request 118290: Streamline Comment fields of KCMs

2014-05-29 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118290/#review58732 --- Ship it! - David Edmundson On May 27, 2014, 12:03 a.m., Seb

Re: Review Request 118290: Streamline Comment fields of KCMs

2014-05-26 Thread Sebastian Kügler
> On May 26, 2014, 11:34 p.m., Christoph Feck wrote: > > kcms/hardware/display/display.desktop, line 100 > > > > > > & Initially forgot this one. I've fixed it locally already. Won't update the patch here just

Re: Review Request 118290: Streamline Comment fields of KCMs

2014-05-26 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118290/ --- (Updated May 27, 2014, 12:03 a.m.) Review request for Localization and Tr

Re: Review Request 118290: Streamline Comment fields of KCMs

2014-05-26 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118290/#review58531 --- kcms/hardware/display/display.desktop

Re: Review Request 118290: Streamline Comment fields of KCMs

2014-05-26 Thread Heiko Tietze
> On May 26, 2014, 10:38 a.m., Christoph Feck wrote: > > kcms/dateandtime/clock.desktop, line 107 > > > > > > Is there a guideline for using the '&' character vs. "and"? I suggest > > to always use the word (whi

Re: Review Request 118290: Streamline Comment fields of KCMs

2014-05-26 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118290/ --- (Updated May 26, 2014, 10:52 p.m.) Review request for Plasma and KDE Usab

Re: Review Request 118290: Streamline Comment fields of KCMs

2014-05-26 Thread Sebastian Kügler
> On May 26, 2014, 10:38 a.m., Christoph Feck wrote: > > kcms/formats/formats.desktop, line 27 > > > > > > Missing comma before the "and". No comma there, the and replaces it. > On May 26, 2014, 10:38 a.m., Chr

Re: Review Request 118290: Streamline Comment fields of KCMs

2014-05-26 Thread David Edmundson
> On May 26, 2014, 10:38 a.m., Christoph Feck wrote: > > kcms/colors/colors.desktop, line 106 > > > > > > I am not native english, but I think "Application's Color Scheme" is > > correct. Application's color sc

Re: Review Request 118290: Streamline Comment fields of KCMs

2014-05-26 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118290/#review58456 --- kcms/colors/colors.desktop

Re: Review Request 118290: Streamline Comment fields of KCMs

2014-05-26 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118290/ --- (Updated May 26, 2014, 8:49 a.m.) Review request for Plasma and KDE Usabi

Re: Review Request 118290: Streamline Comment fields of KCMs

2014-05-25 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118290/#review58432 --- They look better to me, maybe you can run it by the usability

Review Request 118290: Streamline Comment fields of KCMs

2014-05-23 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118290/ --- Review request for Plasma. Repository: plasma-desktop Description -