Re: Review Request 117691: Unload libplasma after using it in Plasma Media Center

2014-04-26 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117691/ --- (Updated April 26, 2014, 6:17 p.m.) Status -- This change has been m

Re: Review Request 117691: Unload libplasma after using it in Plasma Media Center

2014-04-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117691/#review56644 --- This review has been submitted with commit 2544211adac782faba

Re: Review Request 117691: Unload libplasma after using it in Plasma Media Center

2014-04-24 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117691/#review56459 --- Ship it! Ship It! - Shantanu Tushar On April 24, 2014, 5:4

Re: Review Request 117691: Unload libplasma after using it in Plasma Media Center

2014-04-24 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117691/ --- (Updated April 24, 2014, 5:47 p.m.) Review request for Plasma and Albert

Re: Review Request 117691: Unload libplasma after using it in Plasma Media Center

2014-04-24 Thread Sinny Kumari
> On April 23, 2014, 11:08 p.m., Albert Astals Cid wrote: > > Seems to be an ulra-hack, but if it works, i guess you should commit it if > > it really helps your users to be able to use your product. > > > > Maybe adding a big "TODO" somewhere to recheck if this is needed later on > > or somet

Re: Review Request 117691: Unload libplasma after using it in Plasma Media Center

2014-04-24 Thread Sujith Haridasan
> On April 23, 2014, 11:08 p.m., Albert Astals Cid wrote: > > Seems to be an ulra-hack, but if it works, i guess you should commit it if > > it really helps your users to be able to use your product. > > > > Maybe adding a big "TODO" somewhere to recheck if this is needed later on > > or somet

Re: Review Request 117691: Unload libplasma after using it in Plasma Media Center

2014-04-23 Thread Bhushan Shah
> On April 24, 2014, 4:38 a.m., Albert Astals Cid wrote: > > Seems to be an ulra-hack, but if it works, i guess you should commit it if > > it really helps your users to be able to use your product. > > > > Maybe adding a big "TODO" somewhere to recheck if this is needed later on > > or someth

Re: Review Request 117691: Unload libplasma after using it in Plasma Media Center

2014-04-23 Thread Shantanu Tushar
> On April 23, 2014, 11:08 p.m., Albert Astals Cid wrote: > > Seems to be an ulra-hack, but if it works, i guess you should commit it if > > it really helps your users to be able to use your product. > > > > Maybe adding a big "TODO" somewhere to recheck if this is needed later on > > or somet

Re: Review Request 117691: Unload libplasma after using it in Plasma Media Center

2014-04-23 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117691/#review56339 --- Seems to be an ulra-hack, but if it works, i guess you should

Review Request 117691: Unload libplasma after using it in Plasma Media Center

2014-04-22 Thread Sinny Kumari
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117691/ --- Review request for Plasma and Albert Astals Cid. Repository: plasma-media