Re: Review Request 116796: Show brightness OSD only on user input

2014-03-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116796/#review53425 --- This review has been submitted with commit aa8f0f51201d188d20

Re: Review Request 116796: Show brightness OSD only on user input

2014-03-19 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116796/ --- (Updated March 19, 2014, 3:20 p.m.) Status -- This change has been m

Re: Review Request 116796: Show brightness OSD only on user input

2014-03-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116796/#review53423 --- This review has been submitted with commit 067c2a3f7268c7c250

Re: Review Request 116796: Show brightness OSD only on user input

2014-03-18 Thread Martin Klapetek
> On March 17, 2014, 11:19 p.m., Àlex Fiestas wrote: > > I can't test it but it looks good. > > > > I wonder, can this be put in powerdevil from 4.13? > > Sebastian Kügler wrote: > The DBus interface of plasma-shell is new, so if it's in powerdevil, it > will only work if plasma-shell is r

Re: Review Request 116796: Show brightness OSD only on user input

2014-03-18 Thread Sebastian Kügler
> On March 17, 2014, 10:19 p.m., Àlex Fiestas wrote: > > I can't test it but it looks good. > > > > I wonder, can this be put in powerdevil from 4.13? The DBus interface of plasma-shell is new, so if it's in powerdevil, it will only work if plasma-shell is running, not plasma-desktop. If that'

Re: Review Request 116796: Show brightness OSD only on user input

2014-03-17 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116796/#review53271 --- I can't test it but it looks good. I wonder, can this be put

Re: Review Request 116796: Show brightness OSD only on user input

2014-03-17 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116796/#review53272 --- Ship it! Ship It! - Àlex Fiestas On March 16, 2014, 9:20 p

Re: Review Request 116796: Show brightness OSD only on user input

2014-03-16 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116796/ --- (Updated March 16, 2014, 10:20 p.m.) Review request for Plasma and Àlex F