Re: Review Request 116714: Use CMake config file to find dbusmenu-qt5

2014-03-12 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116714/#review52725 --- completely unrelated question: does someone have a snippet for

Re: Review Request 116714: Use CMake config file to find dbusmenu-qt5

2014-03-12 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116714/ --- (Updated March 12, 2014, 8:27 a.m.) Status -- This change has been m

Re: Review Request 116714: Use CMake config file to find dbusmenu-qt5

2014-03-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116714/#review52724 --- This review has been submitted with commit 6d403bbc24fcaca39a

Re: Review Request 116714: Use CMake config file to find dbusmenu-qt5

2014-03-12 Thread Aurélien Gâteau
> On March 11, 2014, 5:24 p.m., Aleix Pol Gonzalez wrote: > > plasma/generic/dataengines/statusnotifieritem/CMakeLists.txt, line 4 > > > > > > Can't we make the target to export the include directories as well? I

Re: Review Request 116714: Use CMake config file to find dbusmenu-qt5

2014-03-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116714/#review52657 --- Ship it! plasma/generic/dataengines/statusnotifieritem/CMake

Review Request 116714: Use CMake config file to find dbusmenu-qt5

2014-03-11 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116714/ --- Review request for Plasma. Repository: kde-workspace Description --