Re: Review Request 116693: Improve layout of Effect View

> On March 10, 2014, 2:03 p.m., Thomas Pfeiffer wrote: > > File Attachment: Effects View together with the QtQuick Controls text field > > - kwineffects.png > > > > > > The effect names were bold in the Plasma 1 version and they should

Re: Review Request 116693: Improve layout of Effect View

> On March 10, 2014, 2:03 p.m., Thomas Pfeiffer wrote: > > File Attachment: Effects View together with the QtQuick Controls text field > > - kwineffects.png > > > > > > The search field still says "Search Plugins" but should say "Search

Re: Review Request 116693: Improve layout of Effect View

> On March 10, 2014, 2:03 p.m., Thomas Pfeiffer wrote: > > Much better now, thanks for fixing these issues so quickly! > > Just three small things left: I'm going to put up additional review requests for the issues you outlined. Haven't addressed them yet, so they are not issues for this review

Re: Review Request 116693: Improve layout of Effect View

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116693/ --- (Updated March 10, 2014, 1:13 p.m.) Status -- This change has been m

Re: Review Request 116693: Improve layout of Effect View

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116693/#review52538 --- This review has been submitted with commit 6753ae62f49b4e3c75

Re: Review Request 116693: Improve layout of Effect View

> On March 10, 2014, 1:01 p.m., Thomas Pfeiffer wrote: > > Ah, much better now! > > Just three things: > > - The search field still says "Search Plugins" but should say "Search > > Effects" (for consistency) or better still just "Search" (because what else > > should it search for?). Reminds me

Re: Review Request 116693: Improve layout of Effect View

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116693/#review52528 --- Much better now, thanks for fixing these issues so quickly! Ju

Re: Review Request 116693: Improve layout of Effect View

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116693/#review52526 --- Ah, much better now! Just three things: - The search field sti

Re: Review Request 116693: Improve layout of Effect View

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116693/#review52527 --- Ah, much better now! Just three things: - The search field sti

Re: Review Request 116693: Improve layout of Effect View

> On March 10, 2014, 11:15 a.m., David Edmundson wrote: > > qml/Video.qml, line 51 > > > > > > can this become: > > > > visible: videoItem.playbackState != MediaPlayer.StoppedState > > > > and th

Re: Review Request 116693: Improve layout of Effect View

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116693/#review52507 --- Ship it! qml/Video.qml

Review Request 116693: Improve layout of Effect View

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116693/ --- Review request for kwin, Plasma, David Edmundson, Thomas Pfeiffer, and Anto