Re: Review Request 115536: Add window thumbnail to taskmanager

2014-02-09 Thread Kai Uwe Broulik
> On Feb. 7, 2014, 11:47 p.m., Eike Hein wrote: > > Sorry, I missed this yesterday due to an incorrect sieve filter. > > > > As Mark points out the thumbnail sizes will have to be made DPI-aware > > (there's an outstanding user wish for that), but it can go in this way for > > now. I'm merging

Re: Review Request 115536: Add window thumbnail to taskmanager

2014-02-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115536/#review49416 --- This review has been submitted with commit b12619cf723a412ccc

Re: Review Request 115536: Add window thumbnail to taskmanager

2014-02-09 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115536/ --- (Updated Feb. 10, 2014, 7:29 a.m.) Status -- This change has been ma

Re: Review Request 115536: Add window thumbnail to taskmanager

2014-02-09 Thread Kai Uwe Broulik
> On Feb. 7, 2014, 11:47 p.m., Eike Hein wrote: > > Sorry, I missed this yesterday due to an incorrect sieve filter. > > > > As Mark points out the thumbnail sizes will have to be made DPI-aware > > (there's an outstanding user wish for that), but it can go in this way for > > now. I'm merging

Re: Review Request 115536: Add window thumbnail to taskmanager

2014-02-09 Thread Martin Gräßlin
> On Feb. 8, 2014, 12:47 a.m., Eike Hein wrote: > > Sorry, I missed this yesterday due to an incorrect sieve filter. > > > > As Mark points out the thumbnail sizes will have to be made DPI-aware > > (there's an outstanding user wish for that), but it can go in this way for > > now. I'm merging

Re: Review Request 115536: Add window thumbnail to taskmanager

2014-02-07 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115536/#review49229 --- Ship it! Ship It! - Eike Hein On Feb. 7, 2014, 12:44 p.m.,

Re: Review Request 115536: Add window thumbnail to taskmanager

2014-02-07 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115536/#review49228 --- Sorry, I missed this yesterday due to an incorrect sieve filte

Re: Review Request 115536: Add window thumbnail to taskmanager

2014-02-07 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115536/#review49216 --- It might be best to replace all "_s * 2" with "units.largeSpac

Re: Review Request 115536: Add window thumbnail to taskmanager

2014-02-07 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115536/#review49186 --- Ship it! +1 from me, waiting +1 from heike too ;) - Marco Ma

Re: Review Request 115536: Add window thumbnail to taskmanager

2014-02-07 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115536/ --- (Updated Feb. 7, 2014, 1:44 p.m.) Review request for Plasma and Eike Hein

Re: Review Request 115536: Add window thumbnail to taskmanager

2014-02-07 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115536/#review49180 --- for me +1 apart following small issue plasma/desktop/applets

Review Request 115536: Add window thumbnail to taskmanager

2014-02-07 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115536/ --- Review request for Plasma and Eike Hein. Repository: kde-workspace Desc