Re: Review Request 114271: drawFloatFrame for QtQuick menus

2014-01-03 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114271/ --- (Updated Jan. 3, 2014, 8:34 a.m.) Status -- This change has been mar

Re: Review Request 114271: drawFloatFrame for QtQuick menus

2014-01-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114271/#review46658 --- This review has been submitted with commit 50c9f9b0ac26c0d9bf

Re: Review Request 114271: drawFloatFrame for QtQuick menus

2013-12-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114271/ --- (Updated Dec. 16, 2013, 12:03 p.m.) Review request for Plasma, David Edmun

Re: Review Request 114271: drawFloatFrame for QtQuick menus

2013-12-05 Thread Martin Gräßlin
> On Dec. 3, 2013, 3:39 p.m., David Edmundson wrote: > > > > Yichao Yu wrote: > May I ask if how did you get the rounded corner? > > I have got this[1] kind of white frame for menu with rounded corder and > haven't found a good way to get rid of it (without interfering with other

Re: Review Request 114271: drawFloatFrame for QtQuick menus

2013-12-05 Thread Yichao Yu
> On Dec. 3, 2013, 9:39 a.m., David Edmundson wrote: > > > > Yichao Yu wrote: > May I ask if how did you get the rounded corner? > > I have got this[1] kind of white frame for menu with rounded corder and > haven't found a good way to get rid of it (without interfering with other

Re: Review Request 114271: drawFloatFrame for QtQuick menus

2013-12-04 Thread Martin Gräßlin
> On Dec. 3, 2013, 3:39 p.m., David Edmundson wrote: > > > > Yichao Yu wrote: > May I ask if how did you get the rounded corner? > > I have got this[1] kind of white frame for menu with rounded corder and > haven't found a good way to get rid of it (without interfering with other

Re: Review Request 114271: drawFloatFrame for QtQuick menus

2013-12-04 Thread Yichao Yu
> On Dec. 3, 2013, 9:39 a.m., David Edmundson wrote: > > > > Yichao Yu wrote: > May I ask if how did you get the rounded corner? > > I have got this[1] kind of white frame for menu with rounded corder and > haven't found a good way to get rid of it (without interfering with other

Re: Review Request 114271: drawFloatFrame for QtQuick menus

2013-12-04 Thread David Edmundson
> On Dec. 3, 2013, 2:26 p.m., David Edmundson wrote: > > kstyles/oxygen/oxygenstyle.cpp, line 2558 > > > > > > in other cases in this file I've done: > > > > if (option->styleObject->inherits("QQuickStyl

Re: Review Request 114271: drawFloatFrame for QtQuick menus

2013-12-03 Thread Martin Gräßlin
> On Dec. 3, 2013, 3:26 p.m., David Edmundson wrote: > > kstyles/oxygen/oxygenstyle.cpp, line 2558 > > > > > > in other cases in this file I've done: > > > > if (option->styleObject->inherits("QQuickStyl

Re: Review Request 114271: drawFloatFrame for QtQuick menus

2013-12-03 Thread Martin Gräßlin
> On Dec. 3, 2013, 3:39 p.m., David Edmundson wrote: > > > > Yichao Yu wrote: > May I ask if how did you get the rounded corner? > > I have got this[1] kind of white frame for menu with rounded corder and > haven't found a good way to get rid of it (without interfering with other

Re: Review Request 114271: drawFloatFrame for QtQuick menus

2013-12-03 Thread Yichao Yu
> On Dec. 3, 2013, 9:39 a.m., David Edmundson wrote: > > May I ask if how did you get the rounded corner? I have got this[1] kind of white frame for menu with rounded corder and haven't found a good way to get rid of it (without interfering with other things) yet. [1] http://wstaw.org/m/2013/

Re: Review Request 114271: drawFloatFrame for QtQuick menus

2013-12-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114271/#review45041 --- Ship it! - David Edmundson On Dec. 3, 2013, 1:57 p.m., Marti

Re: Review Request 114271: drawFloatFrame for QtQuick menus

2013-12-03 Thread Martin Gräßlin
> On Dec. 3, 2013, 3:26 p.m., David Edmundson wrote: > > kstyles/oxygen/oxygenstyle.cpp, line 2558 > > > > > > in other cases in this file I've done: > > > > if (option->styleObject->inherits("QQuickStyl

Re: Review Request 114271: drawFloatFrame for QtQuick menus

2013-12-03 Thread David Edmundson
> On Dec. 3, 2013, 2:26 p.m., David Edmundson wrote: > > kstyles/oxygen/oxygenstyle.cpp, line 2558 > > > > > > in other cases in this file I've done: > > > > if (option->styleObject->inherits("QQuickStyl

Re: Review Request 114271: drawFloatFrame for QtQuick menus

2013-12-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114271/#review45037 --- kstyles/oxygen/oxygenstyle.cpp

Review Request 114271: drawFloatFrame for QtQuick menus

2013-12-03 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114271/ --- Review request for Plasma, David Edmundson and Hugo Pereira Da Costa. Repo