Re: Review Request 113193: fix some warnings

2013-10-13 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113193/ --- (Updated Oct. 13, 2013, 1:44 p.m.) Status -- This change has been mar

Re: Review Request 113193: fix some warnings

2013-10-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113193/#review41644 --- This review has been submitted with commit e597f66af2f5db3615d

Re: Review Request 113193: fix some warnings

2013-10-12 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113193/#review41616 --- Ship it! Yep. :) - Sebastian Kügler On Oct. 10, 2013, 8:40

Re: Review Request 113193: fix some warnings

2013-10-12 Thread Alexander Richardson
> On Oct. 12, 2013, 9:23 p.m., Sebastian Kügler wrote: > > src/declarativeimports/core/dialog.cpp, line 63 > > > > > > We normally use just 0 for this. I will change that before committing. Otherwise good to go i

Re: Review Request 113193: fix some warnings

2013-10-12 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113193/#review41614 --- Looks good already, some minor comments inline. src/declarati

Re: Review Request 113193: fix some warnings

2013-10-10 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113193/ --- (Updated Oct. 10, 2013, 10:40 p.m.) Review request for Plasma. Repositor

Review Request 113193: fix some warnings

2013-10-10 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113193/ --- Review request for Plasma. Repository: plasma-framework Description