Re: Review Request 113179: Make the runners compile again

2013-10-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113179/#review41533 --- This review has been submitted with commit a3c7a9690f432170015

Re: Review Request 113179: Make the runners compile again

2013-10-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113179/ --- (Updated Oct. 10, 2013, 6:29 p.m.) Status -- This change has been mar

Re: Review Request 113179: Make the runners compile again

2013-10-10 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113179/#review41496 --- Ship it! With the two issues I've pointed out, this patch can

Re: Review Request 113179: Make the runners compile again

2013-10-09 Thread Marco Martin
On Oct. 8, 2013, 9:15 p.m., Aleix Pol Gonzalez wrote: > > There's also runner-related code in > > src/declarativeimports/{core,runnermodel}, these should be reenabled as > > well. Possibly, they also need changes to make built. I had disabled this > > after a discussion with Aaron (who has ref

Re: Review Request 113179: Make the runners compile again

2013-10-09 Thread Kevin Ottens
On Oct. 8, 2013, 9:15 p.m., Aleix Pol Gonzalez wrote: > > There's also runner-related code in > > src/declarativeimports/{core,runnermodel}, these should be reenabled as > > well. Possibly, they also need changes to make built. I had disabled this > > after a discussion with Aaron (who has ref

Re: Review Request 113179: Make the runners compile again

2013-10-08 Thread Sebastian Kügler
On Oct. 8, 2013, 9:15 p.m., Aleix Pol Gonzalez wrote: > > There's also runner-related code in > > src/declarativeimports/{core,runnermodel}, these should be reenabled as > > well. Possibly, they also need changes to make built. I had disabled this > > after a discussion with Aaron (who has ref

Re: Review Request 113179: Make the runners compile again

2013-10-08 Thread Aleix Pol Gonzalez
On Oct. 8, 2013, 9:15 p.m., Aleix Pol Gonzalez wrote: > > There's also runner-related code in > > src/declarativeimports/{core,runnermodel}, these should be reenabled as > > well. Possibly, they also need changes to make built. I had disabled this > > after a discussion with Aaron (who has ref

Re: Review Request 113179: Make the runners compile again

2013-10-08 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113179/#review41412 --- src/plasma/CMakeLists.txt

Review Request 113179: Make the runners compile again

2013-10-08 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113179/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framework