Re: Review Request 112375: Correctly determine frame width when called from QtQuickControls

2013-09-07 Thread David Edmundson
> On Sept. 7, 2013, 7:40 a.m., Hugo Pereira Da Costa wrote: > > kstyles/oxygen/oxygenstyle.cpp, line 619 > > > > > > These changes (612 to 619) are unrelated. Right ? This is just coding > > style. > > I gues

Re: Review Request 112375: Correctly determine frame width when called from QtQuickControls

2013-09-07 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112375/#review39528 --- This review has been submitted with commit f879dccbbf6f4c41122

Re: Review Request 112375: Correctly determine frame width when called from QtQuickControls

2013-09-07 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112375/ --- (Updated Sept. 7, 2013, 1:14 p.m.) Status -- This change has been mar

Re: Review Request 112375: Correctly determine frame width when called from QtQuickControls

2013-09-07 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112375/#review39515 --- Ship it! Ship It! kstyles/oxygen/oxygenstyle.cpp

Re: Review Request 112375: Correctly determine frame width when called from QtQuickControls

2013-09-06 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112375/ --- (Updated Sept. 6, 2013, 9:38 p.m.) Review request for Plasma and Hugo Pere

Re: Review Request 112375: Correctly determine frame width when called from QtQuickControls

2013-08-31 Thread David Edmundson
> On Aug. 31, 2013, 12:14 p.m., Hugo Pereira Da Costa wrote: > > kstyles/oxygen/oxygenstyle.cpp, line 612 > > > > > > Rather than looking up the property multiple times, alongside the > > q_object_cast, I would r

Re: Review Request 112375: Correctly determine frame width when called from QtQuickControls

2013-08-31 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112375/#review39005 --- kstyles/oxygen/oxygenstyle.cpp

Re: Review Request 112375: Correctly determine frame width when called from QtQuickControls

2013-08-30 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112375/ --- (Updated Aug. 30, 2013, 3:55 p.m.) Review request for Plasma and Hugo Pere

Re: Review Request 112375: Correctly determine frame width when called from QtQuickControls

2013-08-30 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112375/ --- (Updated Aug. 30, 2013, 3:56 p.m.) Review request for Plasma and Hugo Pere