Re: Review Request 112033: Drop windowId property from PlasmaCore.Dialog

2013-08-19 Thread Martin Gräßlin
> On Aug. 19, 2013, 10:33 a.m., Aleix Pol Gonzalez wrote: > > FWIW this is also being used in the KTp chat plasmoid, in a hack so the > > dialog doesn't appear in the tasks list. well that should be done differently. IIRC the PlasmaCore.Dialog already exposes a flags attribute, so we should ma

Re: Review Request 112033: Drop windowId property from PlasmaCore.Dialog

2013-08-19 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112033/#review38100 --- FWIW this is also being used in the KTp chat plasmoid, in a hac

Re: Review Request 112033: Drop windowId property from PlasmaCore.Dialog

2013-08-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112033/ --- (Updated Aug. 13, 2013, 4:47 a.m.) Status -- This change has been mar

Re: Review Request 112033: Drop windowId property from PlasmaCore.Dialog

2013-08-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112033/#review37635 --- This review has been submitted with commit f50a5412ba83058dcbf

Re: Review Request 112033: Drop windowId property from PlasmaCore.Dialog

2013-08-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112033/#review37620 --- Ship it! Ship It! - Marco Martin On Aug. 12, 2013, 5:34 p.m

Re: Review Request 112033: Drop windowId property from PlasmaCore.Dialog

2013-08-12 Thread Marco Martin
> On Aug. 12, 2013, 5:50 p.m., Ivan Čukić wrote: > > Isn't it also used for reporting wid to share-like-connect (activity > > manager) in some applications? > > Martin Gräßlin wrote: > well it got introduced for KWin: > > commit 52bc2bd662b0e82191922d8fc81b74cc2895d3c0 > Author

Re: Review Request 112033: Drop windowId property from PlasmaCore.Dialog

2013-08-12 Thread Ivan Čukić
> On Aug. 12, 2013, 5:50 p.m., Ivan Čukić wrote: > > Isn't it also used for reporting wid to share-like-connect (activity > > manager) in some applications? > > Martin Gräßlin wrote: > well it got introduced for KWin: > > commit 52bc2bd662b0e82191922d8fc81b74cc2895d3c0 > Author

Re: Review Request 112033: Drop windowId property from PlasmaCore.Dialog

2013-08-12 Thread Martin Gräßlin
> On Aug. 12, 2013, 7:50 p.m., Ivan Čukić wrote: > > Isn't it also used for reporting wid to share-like-connect (activity > > manager) in some applications? well it got introduced for KWin: commit 52bc2bd662b0e82191922d8fc81b74cc2895d3c0 Author: Martin Gräßlin Date: Sat Mar 24 10:51:12 2012

Re: Review Request 112033: Drop windowId property from PlasmaCore.Dialog

2013-08-12 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112033/#review37602 --- Isn't it also used for reporting wid to share-like-connect (act

Review Request 112033: Drop windowId property from PlasmaCore.Dialog

2013-08-12 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112033/ --- Review request for Plasma and Marco Martin. Description --- Property