Re: Review Request 109684: Make code python3 compatible.

2015-08-31 Thread Michael Jansen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109684/ --- (Updated Aug. 31, 2015, 10:42 a.m.) Status -- This change has been m

Re: Review Request 109684: Make code python3 compatible.

2015-08-31 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109684/#review84630 --- Given you didn't get back to Luca's comment, I'm going to clos

Re: Review Request 109684: Make code python3 compatible.

2013-03-24 Thread Luca Beltrame
In data domenica 24 marzo 2013 00:55:25, Michael Jansen ha scritto: > No problem with that. Was the easiest solution for kross. > Should i go forward and do that? Go ahead. Just to stay on the safe side, can you make a new RR once you're done with that? -- Luca Beltrame - KDE Forums team KDE S

Re: Review Request 109684: Make code python3 compatible.

2013-03-23 Thread Michael Jansen
On Sunday, March 24, 2013 12:49:11 AM Luca Beltrame wrote: > In data domenica 24 marzo 2013 00:45:46, Michael Jansen ha scritto: > > The we should for now do as i did for kross (another thing that has to be > > made python3 compatible) > > Rather than setting everything to false I would just exclu

Re: Review Request 109684: Make code python3 compatible.

2013-03-23 Thread Luca Beltrame
In data domenica 24 marzo 2013 00:45:46, Michael Jansen ha scritto: > The we should for now do as i did for kross (another thing that has to be > made python3 compatible) Rather than setting everything to false I would just exclude include_directories with the script engine if Py > 2 is found (m

Re: Review Request 109684: Make code python3 compatible.

2013-03-23 Thread Michael Jansen
On Saturday, March 23, 2013 11:37:18 PM Luca Beltrame wrote: > > On March 23, 2013, 11:35 p.m., Luca Beltrame wrote: > > > The issue is much deeper than this specific piece of code. In fact, > > > fixing this part will not make the code Py3 compatible. The real > > > problematic code is in PyKDE4,

Re: Review Request 109684: Make code python3 compatible.

2013-03-23 Thread Luca Beltrame
> On March 23, 2013, 11:35 p.m., Luca Beltrame wrote: > > The issue is much deeper than this specific piece of code. In fact, fixing > > this part will not make the code Py3 compatible. The real problematic code > > is in PyKDE4, to be precise the kpythonpluginfactory (kpythonpluginfactory/ >

Re: Review Request 109684: Make code python3 compatible.

2013-03-23 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109684/#review29772 --- The issue is much deeper than this specific piece of code. In f

Review Request 109684: Make code python3 compatible.

2013-03-23 Thread Michael Jansen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109684/ --- Review request for Plasma and Luca Beltrame. Description --- Make cod