Re: Review Request 109648: Implement the implicitWidth/implicitHeight of the chat plasmoid

2013-03-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109648/ --- (Updated March 29, 2013, 12:10 a.m.) Status -- This change has been m

Re: Review Request 109648: Implement the implicitWidth/implicitHeight of the chat plasmoid

2013-03-22 Thread Marco Martin
> On March 21, 2013, 6:54 p.m., David Edmundson wrote: > > I'm very much against shipping any patches if we don't know why it fixes > > it. From what I can see from declarative/declarativeitemcontainer.cpp it > > just sets the minimumWidth to it... which I would have thought it would be > > do

Re: Review Request 109648: Implement the implicitWidth/implicitHeight of the chat plasmoid

2013-03-22 Thread David Edmundson
> On March 21, 2013, 6:54 p.m., David Edmundson wrote: > > I'm very much against shipping any patches if we don't know why it fixes > > it. From what I can see from declarative/declarativeitemcontainer.cpp it > > just sets the minimumWidth to it... which I would have thought it would be > > do

Re: Review Request 109648: Implement the implicitWidth/implicitHeight of the chat plasmoid

2013-03-22 Thread Marco Martin
> On March 21, 2013, 6:54 p.m., David Edmundson wrote: > > I'm very much against shipping any patches if we don't know why it fixes > > it. From what I can see from declarative/declarativeitemcontainer.cpp it > > just sets the minimumWidth to it... which I would have thought it would be > > do

Re: Review Request 109648: Implement the implicitWidth/implicitHeight of the chat plasmoid

2013-03-21 Thread Aleix Pol Gonzalez
> On March 21, 2013, 6:54 p.m., David Edmundson wrote: > > I'm very much against shipping any patches if we don't know why it fixes > > it. From what I can see from declarative/declarativeitemcontainer.cpp it > > just sets the minimumWidth to it... which I would have thought it would be > > do

Re: Review Request 109648: Implement the implicitWidth/implicitHeight of the chat plasmoid

2013-03-21 Thread Marco Martin
> On March 21, 2013, 6:54 p.m., David Edmundson wrote: > > I'm very much against shipping any patches if we don't know why it fixes > > it. From what I can see from declarative/declarativeitemcontainer.cpp it > > just sets the minimumWidth to it... which I would have thought it would be > > do

Re: Review Request 109648: Implement the implicitWidth/implicitHeight of the chat plasmoid

2013-03-21 Thread Àlex Fiestas
> On March 21, 2013, 7:11 p.m., Marco Martin wrote: > > Ship It! Marco, can you bring some light into David ramblings? Any doc on implicit/preferred/minimum width? - Àlex --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 109648: Implement the implicitWidth/implicitHeight of the chat plasmoid

2013-03-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109648/#review29653 --- Ship it! Ship It! - Marco Martin On March 21, 2013, 5:37 p.

Re: Review Request 109648: Implement the implicitWidth/implicitHeight of the chat plasmoid

2013-03-21 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109648/#review29651 --- Ship it! I'm very much against shipping any patches if we don'

Review Request 109648: Implement the implicitWidth/implicitHeight of the chat plasmoid

2013-03-21 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109648/ --- Review request for Plasma, Telepathy and David Edmundson. Description