Re: Review Request 108438: Use translucent/dialogs/background elements where possible

2013-01-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108438/#review26430 --- This review has been submitted with commit 0be3da58b8a219e458c

Re: Review Request 108438: Use translucent/dialogs/background elements where possible

2013-01-30 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108438/#review26419 --- Ship it! Ship It! - Thomas Lübking On Jan. 30, 2013, 1:28 p

Re: Review Request 108438: Use translucent/dialogs/background elements where possible

2013-01-30 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108438/ --- (Updated Jan. 30, 2013, 2:28 p.m.) Review request for kwin, Plasma, Sebast

Re: Review Request 108438: Use translucent/dialogs/background elements where possible

2013-01-30 Thread Martin Gräßlin
> On Jan. 30, 2013, 10:41 a.m., Thomas Lübking wrote: > > kwin/tabbox/declarative.cpp, line 115 > > > > > > No idea how expensive this is (eg. whether there's an I/O) but it could > > be cached (since iirc we con

Re: Review Request 108438: Use translucent/dialogs/background elements where possible

2013-01-30 Thread Martin Gräßlin
> On Jan. 30, 2013, 10:41 a.m., Thomas Lübking wrote: > > kwin/tabbox/declarative.cpp, line 111 > > > > > > Looking into the air theme, there seem to be 3 variants to catch. > > > > dialogs/background (de

Re: Review Request 108438: Use translucent/dialogs/background elements where possible

2013-01-30 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108438/#review26404 --- kwin/effects/desktopgrid/desktopgrid.cpp

Re: Review Request 108438: Use translucent/dialogs/background elements where possible

2013-01-29 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108438/ --- (Updated Jan. 30, 2013, 8:25 a.m.) Review request for kwin, Plasma, Sebast

Re: Review Request 108438: Use translucent/dialogs/background elements where possible

2013-01-21 Thread Aaron J. Seigo
On Wednesday, January 16, 2013 20:22:56 Martin Gräßlin wrote: > I will look into it tomorrow again - maybe Aaron found a solution for KWin > tells libplasma that we use compositing ;-) i don't think we can do anything sensible for libplasma1 ... what we need to be able to do is have the applica

Re: Review Request 108438: Use translucent/dialogs/background elements where possible

2013-01-16 Thread Martin Gräßlin
> On Jan. 16, 2013, 6:58 p.m., Sebastian Kügler wrote: > > This patch brings a big improvement on the contrast, works better even than > > I expected. :) > > > > On KDE/4.10 I'm getting the following build error: > > > > /home/sebas/kdesvn/src/kde-workspace/kwin/tabbox/../workspace.h: In > >

Re: Review Request 108438: Use translucent/dialogs/background elements where possible

2013-01-16 Thread Thomas Lübking
> On Jan. 16, 2013, 5:58 p.m., Sebastian Kügler wrote: > > This patch brings a big improvement on the contrast, works better even than > > I expected. :) > > > > On KDE/4.10 I'm getting the following build error: > > > > /home/sebas/kdesvn/src/kde-workspace/kwin/tabbox/../workspace.h: In > >

Re: Review Request 108438: Use translucent/dialogs/background elements where possible

2013-01-16 Thread Sebastian Kügler
> On Jan. 16, 2013, 5:58 p.m., Sebastian Kügler wrote: > > This patch brings a big improvement on the contrast, works better even than > > I expected. :) > > > > On KDE/4.10 I'm getting the following build error: > > > > /home/sebas/kdesvn/src/kde-workspace/kwin/tabbox/../workspace.h: In > >

Re: Review Request 108438: Use translucent/dialogs/background elements where possible

2013-01-16 Thread Thomas Lübking
> On Jan. 16, 2013, 5:58 p.m., Sebastian Kügler wrote: > > This patch brings a big improvement on the contrast, works better even than > > I expected. :) > > > > On KDE/4.10 I'm getting the following build error: > > > > /home/sebas/kdesvn/src/kde-workspace/kwin/tabbox/../workspace.h: In > >

Re: Review Request 108438: Use translucent/dialogs/background elements where possible

2013-01-16 Thread Martin Gräßlin
> On Jan. 16, 2013, 6:58 p.m., Sebastian Kügler wrote: > > This patch brings a big improvement on the contrast, works better even than > > I expected. :) > > > > On KDE/4.10 I'm getting the following build error: > > > > /home/sebas/kdesvn/src/kde-workspace/kwin/tabbox/../workspace.h: In > >

Re: Review Request 108438: Use translucent/dialogs/background elements where possible

2013-01-16 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108438/#review25679 --- This patch brings a big improvement on the contrast, works bett

Re: Review Request 108438: Use translucent/dialogs/background elements where possible

2013-01-16 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108438/#review25666 --- No problem for the effects, but insufficient for the tabbox bec

Re: Review Request 108438: Use translucent/dialogs/background elements where possible

2013-01-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108438/#review25662 --- the patch seems to create some regressions, because I changed t

Review Request 108438: Use translucent/dialogs/background elements where possible

2013-01-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108438/ --- Review request for kwin, Plasma, Sebastian Kügler, and Xuetian Weng. Descr