Re: Review Request: taskmanager library: Manual Sorting Fix

2009-11-24 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1526/#review3259 --- Ship it! looks ok; let's get this into svn and start testing it under

Re: Review Request: taskmanager library: Manual Sorting Fix

2009-11-24 Thread Christian Mollekopf
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1526/ --- (Updated 2009-11-24 22:21:35.429523) Review request for Plasma, Aaron Seigo and

Re: Review Request: taskmanager library: Manual Sorting Fix

2009-11-23 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1526/#review3243 --- /trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupableitem.h

Re: Review Request: taskmanager library: Manual Sorting Fix

2009-11-21 Thread Christian Mollekopf
> On 2009-09-04 20:16:52, Aaron Seigo wrote: > > this results in a "leak" in that every window ever created will have an > > item that stays forever, no? shouldn't it only keep track of winIds that > > still exist, and do so in the manual grouping strategy? > > Christian Mollekopf wrote: >

Re: Review Request: taskmanager library: Manual Sorting Fix

2009-11-21 Thread Beat Wolf
> On 2009-09-04 20:16:52, Aaron Seigo wrote: > > this results in a "leak" in that every window ever created will have an > > item that stays forever, no? shouldn't it only keep track of winIds that > > still exist, and do so in the manual grouping strategy? > > Christian Mollekopf wrote: >

Re: Review Request: taskmanager library: Manual Sorting Fix

2009-10-19 Thread Christian Mollekopf
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1526/ --- (Updated 2009-10-19 21:10:07.356467) Review request for Plasma, Aaron Seigo and

Re: Review Request: taskmanager library: Manual Sorting Fix

2009-10-17 Thread Christian Mollekopf
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1526/ --- (Updated 2009-10-17 16:57:29.802942) Review request for Plasma, Aaron Seigo and

Re: Review Request: taskmanager library: Manual Sorting Fix

2009-09-30 Thread Christian Mollekopf
On Wednesday 30 September 2009 01:35:41 j...@progsoc.org wrote: > > On 2009-09-04 20:16:52, Aaron Seigo wrote: > > > this results in a "leak" in that every window ever created will have an > > > item that stays forever, no? shouldn't it only keep track of winIds > > > that still exist, and do so in

Re: Review Request: taskmanager library: Manual Sorting Fix

2009-09-29 Thread jedd
> On 2009-09-04 20:16:52, Aaron Seigo wrote: > > this results in a "leak" in that every window ever created will have an > > item that stays forever, no? shouldn't it only keep track of winIds that > > still exist, and do so in the manual grouping strategy? > > Christian Mollekopf wrote: >

Re: Review Request: taskmanager library: Manual Sorting Fix

2009-09-29 Thread Christian Mollekopf
> On 2009-09-04 20:16:52, Aaron Seigo wrote: > > this results in a "leak" in that every window ever created will have an > > item that stays forever, no? shouldn't it only keep track of winIds that > > still exist, and do so in the manual grouping strategy? > > Christian Mollekopf wrote: >

Re: Review Request: taskmanager library: Manual Sorting Fix

2009-09-28 Thread Aaron Seigo
> On 2009-09-04 20:16:52, Aaron Seigo wrote: > > this results in a "leak" in that every window ever created will have an > > item that stays forever, no? shouldn't it only keep track of winIds that > > still exist, and do so in the manual grouping strategy? > > Christian Mollekopf wrote: >

Re: Review Request: taskmanager library: Manual Sorting Fix

2009-09-28 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1526/ --- (Updated 2009-09-28 20:26:09.228700) Review request for Plasma, Aaron Seigo and

Re: Review Request: taskmanager library: Manual Sorting Fix

2009-09-06 Thread Christian Mollekopf
> On 2009-09-04 20:16:52, Aaron Seigo wrote: > > this results in a "leak" in that every window ever created will have an > > item that stays forever, no? shouldn't it only keep track of winIds that > > still exist, and do so in the manual grouping strategy? Yes this would result in a "leak" (a

Re: Review Request: taskmanager library: Manual Sorting Fix

2009-09-04 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1526/#review2247 --- this results in a "leak" in that every window ever created will have a

Review Request: taskmanager library: Manual Sorting Fix

2009-09-04 Thread Christian Mollekopf
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1526/ --- Review request for Plasma, Aaron Seigo and Marco Martin. Summary --- this f