> On 2009-01-19 08:24:39, Sebastian Kügler wrote:
> > Thanks for having a look into it. (I've not tested it yet.)
Don't ship it!
"
dannyK says your brightness keys patch will be problematic with most current
machines, as they do brightness control in hardware. apparently there's a hal
prope
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/335/#review328
---
Ship it!
Thanks for having a look into it. (I've not tested it ye
On Sunday 18 January 2009 13:10:11 you wrote:
> On Sunday 18 January 2009 19:38:19 Aaron J. Seigo wrote:
> > On Sunday 18 January 2009, Artur Souza (MoRpHeUz) wrote:
> > > On Sun, Jan 18, 2009 at 11:50 AM, Michael Jansen
> > >
> >
> > wrote:
> > > > Why not use KActions here? Any reason for that?
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/335/
---
(Updated 2009-01-18 12:22:12.793310)
Review request for Plasma.
Summary
-
On Sunday 18 January 2009 19:38:19 Aaron J. Seigo wrote:
> On Sunday 18 January 2009, Artur Souza (MoRpHeUz) wrote:
> > On Sun, Jan 18, 2009 at 11:50 AM, Michael Jansen
>
> wrote:
> > > Why not use KActions here? Any reason for that?
> >
> > Actually KActions would do the job, yes... =)
>
> given
On domenica 18 gennaio 2009 19:38:23 Aaron Seigo wrote:
> my only concern is whether or not the battery applet is the "right" place
> for this. i think this makes more sense either as a kded module or in the
> desktop shell itself. even if the battery applet isn't around, those keys
> should probab
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/335/#review324
---
other than the coding style (we use the kdelibs style) this patch
On Sunday 18 January 2009, Artur Souza (MoRpHeUz) wrote:
> On Sun, Jan 18, 2009 at 11:50 AM, Michael Jansen
wrote:
> > Why not use KActions here? Any reason for that?
>
> Actually KActions would do the job, yes... =)
given that Qt doesn't know about these keys, it probably wouldn't work so well
On Sun, Jan 18, 2009 at 11:50 AM, Michael Jansen
wrote:
> Why not use KActions here? Any reason for that?
Actually KActions would do the job, yes... =)
Cheers,
--
---
Artur Duque de Souza
OpenBossa Research Labs
INdT - Instituto Nokia de Tec
On Sunday 18 January 2009 15:23:23 Artur Souza (MoRpHeUz) wrote:
> Hi =)
>
> On Sun, Jan 18, 2009 at 1:19 AM, Matt Rogers wrote:
> > This patch adds support for laptop brightness keys on X11. Qt doesn't
> > support these keys yet, so this has to be implemented in a platform
> > specific way and I
Hi =)
On Sun, Jan 18, 2009 at 1:19 AM, Matt Rogers wrote:
> This patch adds support for laptop brightness keys on X11. Qt doesn't support
> these keys yet, so this has to be implemented in a platform specific way and
> I have provided support for them on X11.
Would be a good idea to make the k
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/335/
---
Review request for Plasma.
Summary
---
This patch adds support for lap
12 matches
Mail list logo
