Re: Review Request: remove Assert on collection id change

2011-02-26 Thread Sergio Luis Martins
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100523/#review1656 --- I fixed kdepim/calendarsupport/calendar.cpp. It now handles mov

Re: Review Request: remove Assert on collection id change

2011-02-16 Thread Sergio Luis Martins
> On Feb. 14, 2011, 9:37 p.m., John Layt wrote: > > This is in a file copied in from Akonadi and I would strongly prefer us not > > to patch them up in plasma. I intend to occasionally update the code from > > Akonadi until such time as the required classes become public and we can > > delete

Re: Review Request: remove Assert on collection id change

2011-02-14 Thread John Layt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100523/#review1441 --- This is in a file copied in from Akonadi and I would strongly pr

Re: Review Request: remove Assert on collection id change

2011-02-14 Thread Mario Bensi
> On Feb. 4, 2011, 6:54 p.m., Sergio Luis Martins wrote: > > I don't know if calendar.cpp will support moves just by removing that > > assert. Will have to read the code in the weekend. > > Mario Bensi wrote: > I'm not sure the code support moves but this remove don't create new > crash.

Re: Review Request: remove Assert on collection id change

2011-02-06 Thread Mario Bensi
> On Feb. 4, 2011, 6:54 p.m., Sergio Luis Martins wrote: > > I don't know if calendar.cpp will support moves just by removing that > > assert. Will have to read the code in the weekend. I'm not sure the code support moves but this remove don't create new crash. - Mario -

Re: Review Request: remove Assert on collection id change

2011-02-04 Thread Sergio Luis Martins
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100523/#review1229 --- I don't know if calendar.cpp will support moves just by removing

Review Request: remove Assert on collection id change

2011-02-02 Thread Mario Bensi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100523/ --- Review request for KDEPIM and Plasma. Summary --- Actually, there is