Re: Review Request: merging screen edges settings.

2010-03-10 Thread Davide Bettio
> On 2010-03-10 19:44:48, Lubos Lunak wrote: > > Looks ok to me. > > > > One small nitpick: Please do not do > > Foo* foo = new Foo; > > foo->doSomething(); > > delete foo; > > > > The object can be normally allocated on the stack without risking a leak or > > requiring the extra work of dynam

Re: Review Request: merging screen edges settings.

2010-03-10 Thread Lubos Lunak
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3240/#review4458 --- Ship it! Looks ok to me. One small nitpick: Please do not do Foo* fo

Re: Review Request: merging screen edges settings.

2010-03-10 Thread Lubos Lunak
On Wednesday 10 of March 2010, Sebastian Kügler wrote: > On Wednesday 10 March 2010 13:22:04 Davide Bettio wrote: > > > On 2010-03-10 07:28:38, Martin Gräßlin wrote: > > > > Why do we still need prevent screen locking? It seems to do nothing, > > > > so I would say it can be removed completely. > >

Re: Review Request: merging screen edges settings.

2010-03-10 Thread Aaron J. Seigo
On March 10, 2010, Sebastian Kügler wrote: > This is a non-feature IMO as it's hardly discoverable and can easily result > a screen not getting locked because the user left the mouse in the wrong > position, leading to security risks. a) people do use this (i even worked on improvements to the fea

Re: Re: Review Request: merging screen edges settings.

2010-03-10 Thread todd rme
On Wed, Mar 10, 2010 at 12:35 PM, wrote: > Just to give a bit of perspective -- I have seen this type of behavior on > other platforms before. It's been around for several years so it's not > completely out of the blue. > > Of course, I can't remember the specifics. It seems to me that it may hav

Re: Re: Review Request: merging screen edges settings.

2010-03-10 Thread wspeir
Just to give a bit of perspective -- I have seen this type of behavior on other platforms before. It's been around for several years so it's not completely out of the blue. Of course, I can't remember the specifics. It seems to me that it may have been an add-on behavior to Windows or the A

Re: Review Request: merging screen edges settings.

2010-03-10 Thread Marco Martin
On Wednesday 10 March 2010, Sebastian Kügler wrote: > On Wednesday 10 March 2010 13:22:04 Davide Bettio wrote: > > > On 2010-03-10 07:28:38, Martin Gräßlin wrote: > > > > Why do we still need prevent screen locking? It seems to do nothing, > > > > so I would say it can be removed completely. > > >

Re: Review Request: merging screen edges settings.

2010-03-10 Thread Sebastian Kügler
On Wednesday 10 March 2010 13:22:04 Davide Bettio wrote: > > On 2010-03-10 07:28:38, Martin Gräßlin wrote: > > > Why do we still need prevent screen locking? It seems to do nothing, so > > > I would say it can be removed completely. > > If you keep the mouse in a corner the screensaver will not st

Re: Review Request: merging screen edges settings.

2010-03-10 Thread Martin Gräßlin
> On 2010-03-10 07:28:38, Martin Gräßlin wrote: > > Why do we still need prevent screen locking? It seems to do nothing, so I > > would say it can be removed completely. > > Davide Bettio wrote: > If you keep the mouse in a corner the screensaver will not start and the > screen will not be

Re: Review Request: merging screen edges settings.

2010-03-10 Thread Davide Bettio
> On 2010-03-10 07:28:38, Martin Gräßlin wrote: > > Why do we still need prevent screen locking? It seems to do nothing, so I > > would say it can be removed completely. If you keep the mouse in a corner the screensaver will not start and the screen will not be locked. - Davide ---

Re: Review Request: merging screen edges settings.

2010-03-09 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3240/#review4441 --- Why do we still need prevent screen locking? It seems to do nothing, s

Review Request: merging screen edges settings.

2010-03-09 Thread Davide Bettio
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3240/ --- Review request for Plasma, Martin Gräßlin and Lubos Lunak. Summary --- 1) R