Re: Review Request: frame plasmoid: image load and scaling with threads

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3162/#review4564 --- I'm totally pro this patch. I'm just curious about the followings..

Re: Review Request: frame plasmoid: image load and scaling with threads

el@kde.org Envoyé: Jeudi 18 Mars 2010 09h40:43 GMT +01:00 Amsterdam / Berlin / Berne / Rome / Stockholm / Vienne Objet: Re: Review Request: frame plasmoid: image load and scaling with threads On Tuesday 16 March 2010 21:07:24 Marco Martin wrote: > to me is fine, > given that we realized in t

Re: Review Request: frame plasmoid: image load and scaling with threads

On Tuesday 16 March 2010 21:07:24 Marco Martin wrote: > to me is fine, > given that we realized in the meantime that also keeping qpixmaps they get > converted in qimages as some point as well, given that this patch is > running on davide pc without major issues since weeks, it's really time to > g

Re: Review Request: frame plasmoid: image load and scaling with threads

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3162/#review4524 --- Ship it! to me is fine, given that we realized in the meantime that a

Re: Review Request: frame plasmoid: image load and scaling with threads

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3162/#review4501 --- Nothing has happened recently, so can I assume that I can ship this pa

Re: Review Request: frame plasmoid: image load and scaling with threads

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3162/#review4448 --- didn't follow so much the issue, but from a quick look at the code see

Re: Review Request: frame plasmoid: image load and scaling with threads

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3162/ --- (Updated 2010-03-09 13:00:26.530767) Review request for Plasma. Changes --

Re: Review Request: frame plasmoid: image load and scaling with threads

On Monday 08 March 2010 23:38:33 Aaron J. Seigo wrote: > On March 8, 2010, Sebastian Kügler wrote: > > Scaling on the GPU is a video card feature. Using a QImage (and thus > > having > > uploading that much data to the video card and then using the hardware > scaling may be slower than keeping th

Re: Review Request: frame plasmoid: image load and scaling with threads

On March 8, 2010, Sebastian Kügler wrote: > Scaling on the GPU is a video card feature. Using a QImage (and thus having uploading that much data to the video card and then using the hardware scaling may be slower than keeping the image in RAM, scaling on the CPU and then doing the data transfer

Re: Review Request: frame plasmoid: image load and scaling with threads

On March 8, 2010, Sebastian Kügler wrote: > On Monday 08 March 2010 19:50:42 Aaron Seigo wrote: > > as far as i can see, the loader is never deleted. it emits its > > signal, > > > > pictureLoaded is called, and then the object is dropped and just sits > > there in memory. > > As far as I

Re: Review Request: frame plasmoid: image load and scaling with threads

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3162/ --- (Updated 2010-03-08 20:19:25.175491) Review request for Plasma. Changes --

Re: Review Request: frame plasmoid: image load and scaling with threads

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3162/ --- (Updated 2010-03-08 20:02:58.196250) Review request for Plasma. Changes --

Re: Review Request: frame plasmoid: image load and scaling with threads

On Monday 08 March 2010 19:50:42 Aaron Seigo wrote: > as far as i can see, the loader is never deleted. it emits its signal, > pictureLoaded is called, and then the object is dropped and just sits > there in memory. As far as I can see, it sits there to hold the image at its original size, wh

Re: Review Request: frame plasmoid: image load and scaling with threads

> On 2010-03-08 18:50:47, Aaron Seigo wrote: > > /trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp, lines 186-190 > > > > > > as far as i can see, the loader is never deleted. it emits its signal, > > pictureLoaded

Re: Review Request: frame plasmoid: image load and scaling with threads

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3162/#review4423 --- /trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp

Re: Review Request: frame plasmoid: image load and scaling with threads

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3162/ --- (Updated 2010-03-08 14:35:28.993575) Review request for Plasma. Changes --

Re: Review Request: frame plasmoid: image load and scaling with threads

On Monday 08 March 2010 14:45:08 Davide Bettio wrote: > anyway the frame behaviour during resize can be improved a lot but honestly > I would prefer to split my work in several small pieces, I don't like huge > patches. Sure, split it up, and submit them separately. I've indicated in my other emai

Re: Review Request: frame plasmoid: image load and scaling with threads

On Monday 08 March 2010 14:33:12 Davide Bettio wrote: > > On 2010-03-08 11:47:49, Sebastian Kügler wrote: > > > I'm not sure about this patch: > > > > > > - The loading of images in a thread is nice > > > - The "loads huge picture and keeps them in mem" is not changed (in > > > fact, it's worse no

Re: Review Request: frame plasmoid: image load and scaling with threads

> On 2010-03-08 11:47:49, Sebastian Kügler wrote: > > I'm not sure about this patch: > > > > - The loading of images in a thread is nice > > - The "loads huge picture and keeps them in mem" is not changed (in fact, > > it's worse now since QImage forces you to keep them in system memory, > > w

Re: Review Request: frame plasmoid: image load and scaling with threads

> On 2010-03-08 11:47:49, Sebastian Kügler wrote: > > /trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp, line 255 > > > > > > This is a hot path (it gets called whenever the applet resizes, which > > can be quite often

Re: Review Request: frame plasmoid: image load and scaling with threads

> On 2010-03-08 11:47:41, Sebastian Kügler wrote: > > /trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp, line 488 > > > > > > Why is this disabled now? oh, sorry, I've forgot it. - Davide --

Re: Review Request: frame plasmoid: image load and scaling with threads

> On 2010-03-08 11:47:49, Sebastian Kügler wrote: > > I'm not sure about this patch: > > > > - The loading of images in a thread is nice > > - The "loads huge picture and keeps them in mem" is not changed (in fact, > > it's worse now since QImage forces you to keep them in system memory, > > w

Re: Review Request: frame plasmoid: image load and scaling with threads

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3162/#review4411 --- I'm not sure about this patch: - The loading of images in a thread is

Re: Review Request: frame plasmoid: image load and scaling with threads

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3162/#review4410 --- I'm not sure about this patch: - The loading of images in a thread is

Re: Review Request: frame plasmoid: image load and scaling with threads

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3162/ --- (Updated 2010-03-08 02:27:47.528025) Review request for Plasma. Changes --

Re: Review Request: frame plasmoid: image load and scaling with threads

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3162/ --- (Updated 2010-03-08 02:24:36.633893) Review request for Plasma. Changes --

Re: Review Request: frame plasmoid: image load and scaling with threads

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3162/#review4398 --- +1 on removing "smooth scaling" from the options. - Aaron On 2010-0

Review Request: frame plasmoid: image load and scaling with threads

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3162/ --- Review request for Plasma. Summary --- First of all: **This is a preview of