Re: Review Request: better handling of Removable property for volumes in soliddevice engine

2012-10-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105432/#review19993 --- This review has been submitted with commit 928a77d199e76bda700

Re: Review Request: better handling of Removable property for volumes in soliddevice engine

2012-10-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105432/#review19991 --- This review has been submitted with commit ec9d4e418ca2327c1a0

Re: Review Request: better handling of Removable property for volumes in soliddevice engine

2012-10-05 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105432/#review19986 --- Ship it! Ship It! - Aaron J. Seigo On Sept. 9, 2012, 7:28 a

Re: Review Request: better handling of Removable property for volumes in soliddevice engine

2012-09-09 Thread Alberto Villa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105432/#review18707 --- If adding that to the Solid API is a problem (because of the KD

Re: Review Request: better handling of Removable property for volumes in soliddevice engine

2012-09-09 Thread Andriy Gapon
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105432/ --- (Updated Sept. 9, 2012, 7:28 a.m.) Review request for Plasma, Solid and Al

Re: Review Request: better handling of Removable property for volumes in soliddevice engine

2012-07-06 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105432/#review15490 --- Just my 2 cents: This piece of API does not seem to belong t

Re: Review Request: better handling of Removable property for volumes in soliddevice engine

2012-07-04 Thread Andriy Gapon
> On July 4, 2012, 10:19 p.m., Alex Fiestas wrote: > > The patch may make sense but, what does it fix exactly? Detection of my USB stick when used with FreeBSD as removable media. - Andriy --- This is an automatically generated e-mail.

Re: Review Request: better handling of Removable property for volumes in soliddevice engine

2012-07-04 Thread Andriy Gapon
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105432/ --- (Updated July 5, 2012, 6:44 a.m.) Review request for Plasma and Solid. C

Re: Review Request: better handling of Removable property for volumes in soliddevice engine

2012-07-04 Thread Alex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105432/#review15388 --- The patch may make sense but, what does it fix exactly? - Alex

Re: Review Request: better handling of Removable property for volumes in soliddevice engine

2012-07-04 Thread Andriy Gapon
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105432/ --- (Updated July 4, 2012, 8:28 a.m.) Review request for Plasma and Solid. D

Review Request: better handling of Removable property for volumes in soliddevice engine

2012-07-04 Thread Andriy Gapon
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105432/ --- Review request for Plasma and Solid. Description --- Currently the co