Re: Review Request: associate an external tool to an applet

2009-09-15 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1606/ --- (Updated 2009-09-15 21:21:51.546388) Review request for Plasma. Summary --

Re: Review Request: associate an external tool to an applet

2009-09-15 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1606/ --- (Updated 2009-09-15 21:12:44.133738) Review request for Plasma. Changes --

Re: Review Request: associate an external tool to an applet

2009-09-15 Thread Aaron Seigo
> On 2009-09-15 04:32:47, Aaron Seigo wrote: > > /trunk/KDE/kdelibs/plasma/applet.h, lines 631-637 > > > > > > external -> associated? > > tool -> application? > > > > we will need to have a non-KService vers

Re: Review Request: associate an external tool to an applet

2009-09-15 Thread Marco Martin
> On 2009-09-15 04:32:47, Aaron Seigo wrote: > > /trunk/KDE/kdelibs/plasma/applet.cpp, lines 1985-1987 > > > > > > this is actually unecessary; KRun does all of this for you, including > > re-using the mimetype fetching

Re: Review Request: associate an external tool to an applet

2009-09-14 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1606/#review2367 --- /trunk/KDE/kdelibs/plasma/applet.h

Review Request: associate an external tool to an applet

2009-09-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1606/ --- Review request for Plasma. Summary --- first implementation of an idea disc