Re: Review Request: an overlay effect element for framesvg

2009-01-13 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/325/#review314 --- Ship it! /trunk/KDE/kdelibs/plasma/applet.cpp

Re: Review Request: an overlay effect element for framesvg

2009-01-13 Thread Marco Martin
On Tuesday 13 January 2009, Aaron J. Seigo wrote: > On Tuesday 13 January 2009, Marco Martin wrote: > > On Tuesday 13 January 2009, Marco Martin wrote: > > > On Monday 12 January 2009, Aaron J. Seigo wrote: > > > > On Monday 12 January 2009, Marco Martin wrote: > > > > > if the possible positions a

Re: Review Request: an overlay effect element for framesvg

2009-01-13 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/325/ --- (Updated 2009-01-13 11:49:21.776481) Review request for Plasma. Summary -

Re: Review Request: an overlay effect element for framesvg

2009-01-13 Thread Nuno Pinheiro
A Tuesday 13 January 2009 17:37:22, Aaron J. Seigo escreveu: > On Tuesday 13 January 2009, Marco Martin wrote: > > On Tuesday 13 January 2009, Marco Martin wrote: > > > On Monday 12 January 2009, Aaron J. Seigo wrote: > > > > On Monday 12 January 2009, Marco Martin wrote: > > > > > if the possible

Re: Review Request: an overlay effect element for framesvg

2009-01-13 Thread Aaron J. Seigo
On Tuesday 13 January 2009, Marco Martin wrote: > On Tuesday 13 January 2009, Marco Martin wrote: > > On Monday 12 January 2009, Aaron J. Seigo wrote: > > > On Monday 12 January 2009, Marco Martin wrote: > > > > if the possible positions are not that much (lets say something like > > > > on the 4 c

Re: Review Request: an overlay effect element for framesvg

2009-01-13 Thread Marco Martin
On Tuesday 13 January 2009, Marco Martin wrote: > On Monday 12 January 2009, Aaron J. Seigo wrote: > > On Monday 12 January 2009, Marco Martin wrote: > > > if the possible positions are not that much (lets say something like on > > > the 4 corners) maybe using a single pixmap for caching would stil

Re: Review Request: an overlay effect element for framesvg

2009-01-13 Thread Marco Martin
On Monday 12 January 2009, Aaron J. Seigo wrote: > On Monday 12 January 2009, Marco Martin wrote: > > if the possible positions are not that much (lets say something like on > > the 4 corners) maybe using a single pixmap for caching would still be > > possible? or maybe just if the position is cons

Re: Review Request: an overlay effect element for framesvg

2009-01-12 Thread Nuno Pinheiro
A Monday 12 January 2009 22:55:11, Aaron J. Seigo escreveu: > On Monday 12 January 2009, Marco Martin wrote: > > if the possible positions are not that much (lets say something like on > > the 4 corners) maybe using a single pixmap for caching would still be > > possible? or maybe just if the posit

Re: Review Request: an overlay effect element for framesvg

2009-01-12 Thread Aaron J. Seigo
On Monday 12 January 2009, Marco Martin wrote: > if the possible positions are not that much (lets say something like on the > 4 corners) maybe using a single pixmap for caching would still be possible? > or maybe just if the position is consistent across instances the impact on > cache would still

Re: Review Request: an overlay effect element for framesvg

2009-01-12 Thread Marco Martin
On Monday 12 January 2009, Aaron J. Seigo wrote: > On Monday 12 January 2009, Marco Martin wrote: > > On Monday 12 January 2009, Aaron J. Seigo wrote: > > > * random position whenever a widget is created. this would result in > > > every widget having a (potentially) unique position, and this posit

Re: Review Request: an overlay effect element for framesvg

2009-01-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/325/ --- (Updated 2009-01-12 14:13:21.430508) Review request for Plasma. Summary -

Re: Review Request: an overlay effect element for framesvg

2009-01-12 Thread Aaron J. Seigo
On Monday 12 January 2009, Nuno Pinheiro wrote: > A Monday 12 January 2009 17:32:57, Aaron J. Seigo escreveu: > > * random position whenever a widget is *first* created. this would result > > in every widget having a (potentially) unique position, but the position > > would remain constant between

Re: Review Request: an overlay effect element for framesvg

2009-01-12 Thread Aaron J. Seigo
On Monday 12 January 2009, Marco Martin wrote: > On Monday 12 January 2009, Aaron J. Seigo wrote: > > * random position whenever a widget is created. this would result in > > every widget having a (potentially) unique position, and this position > > would change between launches of plasma. > > hmm,

Re: Review Request: an overlay effect element for framesvg

2009-01-12 Thread Aaron J. Seigo
On Monday 12 January 2009, Marco Martin wrote: > On Monday 12 January 2009, Aaron J. Seigo wrote: > > On Monday 12 January 2009, Nuno Pinheiro wrote: > > > > define "randomly" > > > > > > The idea for this case was that plasmoid A gets the same exact look > > > every time but the bg of plasmoid A i

Re: Review Request: an overlay effect element for framesvg

2009-01-12 Thread Marco Martin
On Monday 12 January 2009, Aaron J. Seigo wrote: > On Monday 12 January 2009, Nuno Pinheiro wrote: > > > define "randomly" > > > > The idea for this case was that plasmoid A gets the same exact look every > > time but the bg of plasmoid A is diferent from plasmoid B. > > does it matter what the wid

Re: Review Request: an overlay effect element for framesvg

2009-01-12 Thread Nuno Pinheiro
A Monday 12 January 2009 17:32:57, Aaron J. Seigo escreveu: > On Monday 12 January 2009, Nuno Pinheiro wrote: > > > define "randomly" > > > > The idea for this case was that plasmoid A gets the same exact look every > > time but the bg of plasmoid A is diferent from plasmoid B. > > does it matter w

Re: Review Request: an overlay effect element for framesvg

2009-01-12 Thread Aaron J. Seigo
On Monday 12 January 2009, Nuno Pinheiro wrote: > > define "randomly" > > The idea for this case was that plasmoid A gets the same exact look every > time but the bg of plasmoid A is diferent from plasmoid B. does it matter what the widget is (e.g. "digital-clock") or just that it's the same for

Re: Review Request: an overlay effect element for framesvg

2009-01-12 Thread Nuno Pinheiro
A Monday 12 January 2009 17:10:44, Aaron J. Seigo escreveu: > On Monday 12 January 2009, Nuno Pinheiro wrote: > > A Monday 12 January 2009 16:47:30, Aaron J. Seigo escreveu: > > > On Sunday 11 January 2009, Marco Martin wrote: > > > > never scaled, position depending on applet name (eeeh, code for

Re: Review Request: an overlay effect element for framesvg

2009-01-12 Thread Aaron J. Seigo
On Monday 12 January 2009, Nuno Pinheiro wrote: > A Monday 12 January 2009 16:47:30, Aaron J. Seigo escreveu: > > On Sunday 11 January 2009, Marco Martin wrote: > > > never scaled, position depending on applet name (eeeh, code for this is > > > not overly pretty and probably can't be, i know :/) ti

Re: Review Request: an overlay effect element for framesvg

2009-01-12 Thread Nuno Pinheiro
A Monday 12 January 2009 16:47:30, Aaron J. Seigo escreveu: > On Sunday 11 January 2009, Marco Martin wrote: > > never scaled, position depending on applet name (eeeh, code for this is > > not overly pretty and probably can't be, i know :/) tiled > > it can't be based on applet name. that will tie

Re: Review Request: an overlay effect element for framesvg

2009-01-12 Thread Aaron J. Seigo
On Sunday 11 January 2009, Marco Martin wrote: > never scaled, position depending on applet name (eeeh, code for this is not > overly pretty and probably can't be, i know :/) tiled it can't be based on applet name. that will tie themes much, much too tightly to a specific set of applets and will

Review Request: an overlay effect element for framesvg

2009-01-11 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/325/ --- Review request for Plasma. Summary --- since it's 4.3 time... This add