Re: Review Request: Activities Dataengine: avoid calling KActivities::Controller::listActivities() unnecessarily

2011-12-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103358/#review9027 --- This review has been submitted with commit 480db607b4ec63108e18

Re: Review Request: Activities Dataengine: avoid calling KActivities::Controller::listActivities() unnecessarily

2011-12-16 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103358/#review9008 --- Ship it! plasma/generic/dataengines/activities/activityengine.

Re: Review Request: Activities Dataengine: avoid calling KActivities::Controller::listActivities() unnecessarily

2011-12-15 Thread Romário Rios
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103358/ --- (Updated Dec. 16, 2011, 12:25 a.m.) Review request for Plasma. Changes -

Review Request: Activities Dataengine: avoid calling KActivities::Controller::listActivities() unnecessarily

2011-12-07 Thread Romário Rios
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103358/ --- Review request for Plasma. Description --- Avoid calling listActiviti

Re: Review Request: activities dataengine

2010-10-28 Thread Albert Astals Cid
> On 2010-10-28 18:45:00, Albert Astals Cid wrote: > > Which of the strings you add here will be shown to the user? > > Chani Armitage wrote: > none... unless some plasmoid decides to dump the raw data straight to > widgets (which would be dumb in this case) or they're using > plasmaengine

Re: Review Request: activities dataengine

2010-10-28 Thread Chani Armitage
> On 2010-10-28 18:45:00, Albert Astals Cid wrote: > > Which of the strings you add here will be shown to the user? none... unless some plasmoid decides to dump the raw data straight to widgets (which would be dumb in this case) or they're using plasmaengineexplorer (in which case they're a de

Re: Review Request: activities dataengine

2010-10-28 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5707/#review8414 --- Which of the strings you add here will be shown to the user? - Al

Review Request: activities dataengine

2010-10-28 Thread Chani Armitage
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5707/ --- Review request for Plasma and Albert Astals Cid. Summary --- this is a