Re: Review Request: Weather Forecast QML port

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106225/#review18743 --- This review has been submitted with commit 9471e56617a3f2a81dd

Re: Review Request: Weather Forecast QML port

> On Sept. 7, 2012, 5:28 p.m., David Edmundson wrote: > > Fine with me. +1 from me as well - Marco --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106225/#review18666

Re: Review Request: Weather Forecast QML port

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106225/#review18666 --- Ship it! Fine with me. - David Edmundson On Aug. 30, 2012,

Re: Review Request: Weather Forecast QML port

> On Aug. 26, 2012, 9:36 p.m., David Edmundson wrote: > > applets/weather/package/contents/ui/Notice.qml, line 27 > > > > > > Unless there's a good reason, use PlasmaComponents.Label rather than > > Text. Otherwise

Re: Review Request: Weather Forecast QML port

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106225/#review18663 --- Any updates here? - Luis Gabriel Lima On Aug. 30, 2012, 1:53

Re: Review Request: Weather Forecast QML port

> On Aug. 30, 2012, 8:21 a.m., Kai Uwe Broulik wrote: > > applets/weather/package/metadata.desktop, line 17 > > > > > > I think it should not be enabled by default but rather > > X-Plasma-NotificationArea=true >

Re: Review Request: Weather Forecast QML port

> On Aug. 30, 2012, 8:21 a.m., Kai Uwe Broulik wrote: > > applets/weather/package/metadata.desktop, line 17 > > > > > > I think it should not be enabled by default but rather > > X-Plasma-NotificationArea=true >

Re: Review Request: Weather Forecast QML port

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106225/#review18267 --- applets/weather/package/metadata.desktop

Re: Review Request: Weather Forecast QML port

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106225/ --- (Updated Aug. 30, 2012, 1:53 a.m.) Review request for Plasma and Marco Mar

Re: Review Request: Weather Forecast QML port

> On Aug. 26, 2012, 9:36 p.m., David Edmundson wrote: > > applets/weather/package/contents/ui/FiveDaysView.qml, line 70 > > > > > > you don't need this.. just use > > > > color: theColour > > alpha: the

Re: Review Request: Weather Forecast QML port

> On Aug. 26, 2012, 9:36 p.m., David Edmundson wrote: > > applets/weather/package/contents/ui/FiveDaysView.qml, line 70 > > > > > > you don't need this.. just use > > > > color: theColour > > alpha: the

Re: Review Request: Weather Forecast QML port

> On Aug. 26, 2012, 9:36 p.m., David Edmundson wrote: > > applets/weather/CMakeLists.txt, line 15 > > > > > > Where do you use this? Nowhere actually. It was there in the old version and I forgot to remove. Thanks.

Re: Review Request: Weather Forecast QML port

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106225/#review18103 --- applets/weather/package/contents/ui/FiveDaysView.qml

Re: Review Request: Weather Forecast QML port

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106225/#review18054 --- Looks like a very good start. Comments below. applets/weather

Review Request: Weather Forecast QML port

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106225/ --- Review request for Plasma and Marco Martin. Description --- This patc