Re: Review Request: Use libplasmaweather in Weather Wallpaper

2009-04-15 Thread Petri Damstén
> On 2009-04-14 16:22:53, Jonathan Thomas wrote: > > Ooh, looks great! This port is greatly appreciated. Before, setting a new > > location after you set the first one didn't work at all. Now it works, > > unless you set a different location, then try to go back to your old > > location. (E.G.

Re: Review Request: Use libplasmaweather in Weather Wallpaper

2009-04-14 Thread Jonathan Thomas
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/589/#review922 --- Ship it! Ooh, looks great! This port is greatly appreciated. Before, se

Re: Review Request: Use libplasmaweather in Weather Wallpaper

2009-04-14 Thread Petri Damstén
On Wednesday 15 April 2009 01:02:53 Andrew Coles wrote: > i) Geolocation is compulsary, so if it uses IP localisation I'll get the > weather for 200 miles away. A manual override would be useful (i.e. the > old behaviour). It only tries gets the location if source is not configured. User can co

Re: Review Request: Use libplasmaweather in Weather Wallpaper

2009-04-14 Thread Andrew Coles
l Message From: Petri Damstén To: Petri Damstén ; Plasma Sent: Tuesday, 14 April, 2009 22:28:46 Subject: Re: Review Request: Use libplasmaweather in Weather Wallpaper --- This is an automatically generated e-mail. To

Re: Review Request: Use libplasmaweather in Weather Wallpaper

2009-04-14 Thread Petri Damstén
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/589/ --- (Updated 2009-04-14 14:28:46.261240) Review request for Plasma. Changes ---

Review Request: Use libplasmaweather in Weather Wallpaper

2009-04-14 Thread Petri Damstén
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/589/ --- Review request for Plasma. Summary --- Use libplasmaweather WeatherConfig wi