Re: Review Request: Use Product instead of description for device names

2012-10-02 Thread Alex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106637/#review19783 --- We have decided to add some magic in libsolid udisk backend tha

Re: Review Request: Use Product instead of description for device names

2012-09-30 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106637/#review19654 --- Ship it! Ship It! - Jacopo De Simoi On Sept. 29, 2012, 8:21

Re: Review Request: Use Product instead of description for device names

2012-09-30 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106637/#review19631 --- Ship it! very sensible and nice improvement. as long as the pr

Re: Review Request: Use Product instead of description for device names

2012-09-29 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106637/#review19614 --- What will happen if the device name is invalid i.e. empty. Do w

Re: Review Request: Use Product instead of description for device names

2012-09-29 Thread Alex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106637/ --- (Updated Sept. 29, 2012, 8:21 p.m.) Review request for Plasma and Viranch

Re: Review Request: Use Product instead of description for device names

2012-09-29 Thread Alex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106637/ --- (Updated Sept. 29, 2012, 8:21 p.m.) Review request for Plasma and Viranch

Review Request: Use Product instead of description for device names

2012-09-29 Thread Alex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106637/ --- Review request for Plasma and Viranch Mehta. Description --- The desc