Re: Review Request: TaskManager: Store launcher order

2011-11-03 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103006/#review7889 --- Ship it! there are still whitespace issues around "if(" which s

Re: Review Request: TaskManager: Store launcher order

2011-11-02 Thread Craig Drummond
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103006/ --- (Updated Nov. 2, 2011, 10:04 p.m.) Review request for Plasma. Changes --

Re: Review Request: TaskManager: Store launcher order

2011-11-02 Thread Aaron J. Seigo
> On Nov. 1, 2011, 2:56 p.m., Aaron J. Seigo wrote: > > libs/taskmanager/strategies/desktopsortingstrategy.cpp, line 40 > > > > > > this should be a private member of the class ... as this is a > > non-exported clas

Re: Review Request: TaskManager: Store launcher order

2011-11-02 Thread Craig Drummond
> On Nov. 1, 2011, 2:56 p.m., Aaron J. Seigo wrote: > > libs/taskmanager/strategies/desktopsortingstrategy.cpp, line 40 > > > > > > this should be a private member of the class ... as this is a > > non-exported clas

Re: Review Request: TaskManager: Store launcher order

2011-11-01 Thread Craig Drummond
> On Nov. 1, 2011, 2:56 p.m., Aaron J. Seigo wrote: > > libs/taskmanager/taskitem.cpp, lines 171-189 > > > > > > have you done any time measurements on how long this method takes? it > > will be called potentially

Re: Review Request: TaskManager: Store launcher order

2011-11-01 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103006/#review7798 --- usual comment about whitespace correctness; otherwise a few comm

Review Request: TaskManager: Store launcher order

2011-11-01 Thread Craig Drummond
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103006/ --- Review request for Plasma. Description --- 1. Store the order in whic