Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-08 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107160/#review21618 --- Ship it! Ship It! - Aaron J. Seigo On Nov. 7, 2012, 3:20 p.

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-07 Thread Dmitry Ashkadov
> On Nov. 6, 2012, 1:39 p.m., Aaron J. Seigo wrote: > > one small issue with where hiding status is kept. > > > > it may be useful to keep in mind the difference between the data and the > > visualization -> anything that the use can see (e.g. whether an icon is > > hidden or not) is visualiza

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-07 Thread Aaron J. Seigo
> On Nov. 6, 2012, 1:39 p.m., Aaron J. Seigo wrote: > > one small issue with where hiding status is kept. > > > > it may be useful to keep in mind the difference between the data and the > > visualization -> anything that the use can see (e.g. whether an icon is > > hidden or not) is visualiza

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-07 Thread Dmitry Ashkadov
> On Nov. 6, 2012, 1:39 p.m., Aaron J. Seigo wrote: > > one small issue with where hiding status is kept. > > > > it may be useful to keep in mind the difference between the data and the > > visualization -> anything that the use can see (e.g. whether an icon is > > hidden or not) is visualiza

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-07 Thread Dmitry Ashkadov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107160/ --- (Updated Nov. 7, 2012, 3:20 p.m.) Review request for Plasma, Aaron J. Seig

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-07 Thread Dmitry Ashkadov
> On Nov. 6, 2012, 1:39 p.m., Aaron J. Seigo wrote: > > one small issue with where hiding status is kept. > > > > it may be useful to keep in mind the difference between the data and the > > visualization -> anything that the use can see (e.g. whether an icon is > > hidden or not) is visualiza

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-07 Thread Aaron J. Seigo
> On Nov. 6, 2012, 1:39 p.m., Aaron J. Seigo wrote: > > one small issue with where hiding status is kept. > > > > it may be useful to keep in mind the difference between the data and the > > visualization -> anything that the use can see (e.g. whether an icon is > > hidden or not) is visualiza

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-06 Thread Dmitry Ashkadov
> On Nov. 6, 2012, 1:39 p.m., Aaron J. Seigo wrote: > > one small issue with where hiding status is kept. > > > > it may be useful to keep in mind the difference between the data and the > > visualization -> anything that the use can see (e.g. whether an icon is > > hidden or not) is visualiza

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-06 Thread Dmitry Ashkadov
> On Nov. 6, 2012, 1:39 p.m., Aaron J. Seigo wrote: > > one small issue with where hiding status is kept. > > > > it may be useful to keep in mind the difference between the data and the > > visualization -> anything that the use can see (e.g. whether an icon is > > hidden or not) is visualiza

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-06 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107160/#review21486 --- one small issue with where hiding status is kept. it may be us

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-02 Thread Dmitry Ashkadov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107160/ --- (Updated Nov. 2, 2012, 12:40 p.m.) Review request for Plasma, Aaron J. Sei

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-01 Thread Aaron J. Seigo
> On Nov. 1, 2012, 9:47 a.m., Aaron J. Seigo wrote: > > plasma/generic/applets/systemtray/core/manager.h, line 54 > > > > > > the manager is shared across all instances of the system tray plasmoid. > > (look for s_m

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-01 Thread Dmitry Ashkadov
> On Nov. 1, 2012, 9:47 a.m., Aaron J. Seigo wrote: > > plasma/generic/applets/systemtray/core/manager.h, line 54 > > > > > > the manager is shared across all instances of the system tray plasmoid. > > (look for s_m

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-01 Thread Dmitry Ashkadov
> On Nov. 1, 2012, 9:47 a.m., Aaron J. Seigo wrote: > > plasma/generic/applets/systemtray/core/manager.h, line 54 > > > > > > the manager is shared across all instances of the system tray plasmoid. > > (look for s_m

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-01 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107160/#review21280 --- Manager does not need to know about Applet (see comment below a

Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-10-31 Thread Dmitry Ashkadov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107160/ --- Review request for Plasma, Aaron J. Seigo and Marco Martin. Description --