Re: Review Request: State machine architecture for PMC

2010-04-09 Thread Christophe Olinger
> On 2010-04-07 22:25:15, Alessandro Diaferia wrote: > > trunk/playground/base/plasma/MediaCenterComponents/libs/mediacenter/mediacenterstate.h, > > line 73 > > > > > > A method of a library cannot rely on a particular im

Re: Review Request: State machine architecture for PMC

2010-04-08 Thread Christophe Olinger
The medialayout mistake was a very small one, I just removed the class MediaLayout from the mediacenterstate.h, and took the includes for the medialyout from mediacenterstate.cpp into mediacenterstate.h Little C++ mistake from my side. Sorry On Thu, Apr 8, 2010 at 7:30 PM, Alessandro Diaferia wro

Re: Review Request: State machine architecture for PMC

2010-04-08 Thread Alessandro Diaferia
2010/4/8 Marco Martin > On Thursday 08 April 2010, Alessandro Diaferia wrote: > > 2010/4/8 Aaron J. Seigo > > > > > On April 8, 2010, Christophe Olinger wrote: > > > > One thing missing is the layout of the actual subComponents in the > > > > > > applets. > > > > > > > Currently they are just ad

Re: Review Request: State machine architecture for PMC

2010-04-08 Thread Marco Martin
On Thursday 08 April 2010, Alessandro Diaferia wrote: > 2010/4/8 Aaron J. Seigo > > > On April 8, 2010, Christophe Olinger wrote: > > > One thing missing is the layout of the actual subComponents in the > > > > applets. > > > > > Currently they are just added in a row. For this we need the API.

Re: Review Request: State machine architecture for PMC

2010-04-08 Thread Aaron J. Seigo
On April 8, 2010, Alessandro Diaferia wrote: > - Fullscreen > - AppearingFromLeftEdge > - AppearingFromTopEdge > - AppearingFromBottomEdge > - AppearingFromRightEdge > - Invisible we already have Plasma::Location for this, don't we? -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B

Re: Review Request: State machine architecture for PMC

2010-04-08 Thread Alessandro Diaferia
2010/4/8 Aaron J. Seigo > On April 8, 2010, Christophe Olinger wrote: > > One thing missing is the layout of the actual subComponents in the > applets. > > Currently they are just added in a row. For this we need the API. The > > layout should recognize which type of applet arrives and lay it out

Re: Review Request: State machine architecture for PMC

2010-04-08 Thread Christophe Olinger
On Thu, Apr 8, 2010 at 6:42 PM, Aaron J. Seigo wrote: > On April 8, 2010, Christophe Olinger wrote: > > One thing missing is the layout of the actual subComponents in the > applets. > > Currently they are just added in a row. For this we need the API. The > > layout should recognize which type of

Re: Review Request: State machine architecture for PMC

2010-04-08 Thread Aaron J. Seigo
On April 8, 2010, Christophe Olinger wrote: > One thing missing is the layout of the actual subComponents in the applets. > Currently they are just added in a row. For this we need the API. The > layout should recognize which type of applet arrives and lay it out > accordingly. That means lots of i

Re: Fwd: Review Request: State machine architecture for PMC

2010-04-08 Thread Sebastian Kügler
On Thursday 08 April 2010 11:36:52 Marco Martin wrote: > On Thursday 08 April 2010, Christophe Olinger wrote: > > No SVN access yet. This is the first time I work with you guys. Thanks > > for commiting it. I'll read trhough your other mail now > > we need to fix this :) Indeed. Christophe: http:

Re: Review Request: State machine architecture for PMC

2010-04-08 Thread Alessandro Diaferia
2010/4/8 Marco Martin > On Thursday 08 April 2010, Christophe Olinger wrote: > > > I like the idea of the state machine and how it could help us correctly > > > managing the workflow of the mediacenter. Unfortunately i feel > something > > > in the current implementation lacks of robustness (does

Re: Review Request: State machine architecture for PMC

2010-04-08 Thread Marco Martin
On Thursday 08 April 2010, Christophe Olinger wrote: > > I like the idea of the state machine and how it could help us correctly > > managing the workflow of the mediacenter. Unfortunately i feel something > > in the current implementation lacks of robustness (does this word > > exist?). > > > > A

Re: Fwd: Review Request: State machine architecture for PMC

2010-04-08 Thread Marco Martin
On Thursday 08 April 2010, Christophe Olinger wrote: > No SVN access yet. This is the first time I work with you guys. Thanks for > commiting it. I'll read trhough your other mail now > we need to fix this :) Cheers, Marco Martin ___ Plasma-devel maili

Review Request: State machine architecture for PMC

2010-04-08 Thread Christophe Olinger
> > I like the idea of the state machine and how it could help us correctly > managing the workflow of the mediacenter. Unfortunately i feel something in > the current implementation lacks of robustness (does this word exist?). > > As Aaron pointed out, we need to understend whether we are aproachi

Fwd: Review Request: State machine architecture for PMC

2010-04-07 Thread Christophe Olinger
No SVN access yet. This is the first time I work with you guys. Thanks for commiting it. I'll read trhough your other mail now On Thu, Apr 8, 2010 at 8:36 AM, Alessandro Diaferia wrote: > > > > On 2010-04-07 22:25:15, Alessandro Diaferia wrote: > > > Ok, things are getting a little huge. Let's s

Re: Review Request: State machine architecture for PMC

2010-04-07 Thread Alessandro Diaferia
> On 2010-04-07 22:25:15, Alessandro Diaferia wrote: > > Ok, things are getting a little huge. Let's see together how we can come > > out of this. > > > > I like the idea of the state machine and how it could help us correctly > > managing the workflow of the mediacenter. Unfortunately i feel

Re: Review Request: State machine architecture for PMC

2010-04-07 Thread Aaron Seigo
> On 2010-04-07 22:25:15, Alessandro Diaferia wrote: > > Ok, things are getting a little huge. Let's see together how we can come > > out of this. > > > > I like the idea of the state machine and how it could help us correctly > > managing the workflow of the mediacenter. Unfortunately i feel

Re: Review Request: State machine architecture for PMC

2010-04-07 Thread Alessandro Diaferia
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3396/#review4918 --- Ok, things are getting a little huge. Let's see together how we can co

Re: Review Request: State machine architecture for PMC

2010-04-07 Thread Christophe Olinger
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3396/ --- (Updated 2010-04-07 20:59:11.824915) Review request for Plasma. Changes --

Re: Review Request: State machine architecture for PMC

2010-04-07 Thread Christophe Olinger
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3396/ --- (Updated 2010-04-07 20:56:02.469684) Review request for Plasma. Changes --

Re: Review Request: State machine architecture for PMC

2010-04-07 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3396/#review4917 --- i think at this point, we need to make a decision: a) this is definit

Re: Review Request: State machine architecture for PMC

2010-04-07 Thread Christophe Olinger
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3396/ --- (Updated 2010-04-07 17:30:14.244958) Review request for Plasma. Changes --

Re: Review Request: State machine architecture for PMC

2010-04-06 Thread Christophe Olinger
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3396/ --- (Updated 2010-04-06 07:10:39.887751) Review request for Plasma. Changes --