Re: Review Request: Some improments to the system tray notifications.

2008-11-06 Thread Rob Scheepmaker
On Thursday 06 November 2008 13:18:36 Jason Stubbs wrote: > The system tray spec has a balloon message API that is essentially > another notification API. That API describes the icon by its bitmap so I > went for the highest common factor - a QIcon. For Qt, the API is > accessible with QSystemTrayI

Re: Review Request: Some improments to the system tray notifications.

2008-11-06 Thread Jason Stubbs
Rob Scheepmaker wrote: > On Wednesday 05 November 2008 15:18:02 Jason Stubbs wrote: >> Rob Scheepmaker wrote: >>> * The icon us quite large and takes up a lot of space. >>> Solution: remove the icon from the notification itself and use it as the >>> icon of the extenderitem. >> I guess you could ca

Re: Review Request: Some improments to the system tray notifications.

2008-11-06 Thread Rob Scheepmaker
On Wednesday 05 November 2008 15:18:02 Jason Stubbs wrote: > Rob Scheepmaker wrote: > > I noticed a couple of issues in the way system tray notifications are > > currently displayed: > > A little bit cheeky seeing as most of these issues were comments posted > by others on your blog. ;) you caught

Re: Review Request: Some improments to the system tray notifications.

2008-11-05 Thread Jason Stubbs
Rob Scheepmaker wrote: > I noticed a couple of issues in the way system tray notifications are > currently displayed: A little bit cheeky seeing as most of these issues were comments posted by others on your blog. ;) > * The action buttons are hardcoded, and inconsistent with the rest of the >

Re: Review Request: Some improments to the system tray notifications.

2008-11-04 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/256/#review251 --- Ship it! - Aaron On 2008-11-03 16:43:52, Rob Scheepmaker wrote:

Review Request: Some improments to the system tray notifications.

2008-11-03 Thread Rob Scheepmaker
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/256/ --- Review request for Plasma. Summary --- I noticed a couple of issues in