Re: Review Request: Show wallpaper resolution if possible in selection dialog

2009-01-19 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/332/#review330 --- Ship it! there's a number of lines like this: if( m_model )

Re: Review Request: Show wallpaper resolution if possible in selection dialog

2009-01-19 Thread Beat Wolf
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/332/ --- (Updated 2009-01-19 10:07:16.022596) Review request for Plasma. Summary -

Re: Review Request: Show wallpaper resolution if possible in selection dialog

2009-01-19 Thread Beat Wolf
> On 2009-01-18 10:28:02, Aaron Seigo wrote: > > trunk/KDE/kdebase/workspace/plasma/wallpapers/image/backgroundpackage.cpp, > > line 417 > > > > > > still reading in the image here (slow). try: > > > > KFileM

Re: Review Request: Show wallpaper resolution if possible in selection dialog

2009-01-18 Thread Aaron Seigo
> On 2009-01-18 10:28:02, Aaron Seigo wrote: > > i also wonder if we shouldn't have a wallpaper debugging tool; something that would let you select a plugin and see it's config on the left and render it on the right in a widget with proper event forwarding. - Aaron

Re: Review Request: Show wallpaper resolution if possible in selection dialog

2009-01-18 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/332/#review322 --- trunk/KDE/kdebase/workspace/plasma/wallpapers/image/backgroundpac

Re: Review Request: Show wallpaper resolution if possible in selection dialog

2009-01-18 Thread Beat Wolf
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/332/ --- (Updated 2009-01-18 01:21:31.574879) Review request for Plasma. Summary -

Re: Review Request: Show wallpaper resolution if possible in selection dialog

2009-01-18 Thread Beat Wolf
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/332/ --- (Updated 2009-01-18 01:20:49.319193) Review request for Plasma. Summary -

Re: Review Request: Show wallpaper resolution if possible in selection dialog

2009-01-17 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/332/#review320 --- only blocker i see is the performance issue, which should be easy

Re: Review Request: Show wallpaper resolution if possible in selection dialog

2009-01-17 Thread Beat Wolf
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/332/ --- (Updated 2009-01-17 13:58:45.583436) Review request for Plasma. Summary -

Re: Review Request: Show wallpaper resolution if possible in selection dialog

2009-01-17 Thread Beat Wolf
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/332/ --- (Updated 2009-01-17 10:48:51.157380) Review request for Plasma. Summary -

Re: Review Request: Show wallpaper resolution if possible in selection dialog

2009-01-17 Thread Aaron J. Seigo
On Saturday 17 January 2009, Beat Wolf wrote: > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.vidsolbach.de/r/332/ patch seems broken. > Partially solves the wish: http://bugs.kde.org/show_bug.cgi?id=

Review Request: Show wallpaper resolution if possible in selection dialog

2009-01-17 Thread Beat Wolf
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/332/ --- Review request for Plasma. Summary --- Partially solves the wish: http