Re: Review Request: Rewrite kinetic scrolling on ScrollWidget

2010-03-18 Thread Marco Martin
> On 2010-03-17 12:31:22, Marco Martin wrote: > > just by a quick test, the physics seems to work indeed better, it just > > still has some quirks: > > > > - scrollbars aren't syncronized when dragging (yeah i know it needs a mode > > without scrollbars but i would keep them on the desktop) >

Re: Review Request: Rewrite kinetic scrolling on ScrollWidget

2010-03-18 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3312/#review4546 --- Ship it! now it works prefect(tm)! (well, it's still missing the supp

Re: Review Request: Rewrite kinetic scrolling on ScrollWidget

2010-03-17 Thread Zack Rusin
> On 2010-03-17 12:31:22, Marco Martin wrote: > > just by a quick test, the physics seems to work indeed better, it just > > still has some quirks: > > > > - scrollbars aren't syncronized when dragging (yeah i know it needs a mode > > without scrollbars but i would keep them on the desktop) >

Re: Review Request: Rewrite kinetic scrolling on ScrollWidget

2010-03-17 Thread Zack Rusin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3312/ --- (Updated 2010-03-17 22:20:25.287357) Review request for Plasma. Changes --

Re: Review Request: Rewrite kinetic scrolling on ScrollWidget

2010-03-17 Thread Marco Martin
> On 2010-03-17 12:31:22, Marco Martin wrote: > > just by a quick test, the physics seems to work indeed better, it just > > still has some quirks: > > > > - scrollbars aren't syncronized when dragging (yeah i know it needs a mode > > without scrollbars but i would keep them on the desktop) >

Re: Review Request: Rewrite kinetic scrolling on ScrollWidget

2010-03-17 Thread Zack Rusin
> On 2010-03-17 12:31:22, Marco Martin wrote: > > just by a quick test, the physics seems to work indeed better, it just > > still has some quirks: > > > > - scrollbars aren't syncronized when dragging (yeah i know it needs a mode > > without scrollbars but i would keep them on the desktop) >

Re: Review Request: Rewrite kinetic scrolling on ScrollWidget

2010-03-17 Thread Zack Rusin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3312/ --- (Updated 2010-03-17 14:31:13.742901) Review request for Plasma. Changes --

Re: Review Request: Rewrite kinetic scrolling on ScrollWidget

2010-03-17 Thread Artur Souza (MoRpHeUz)
On Wednesday 17 March 2010, 09:20 igorto wrote: > Instead of change the ScrollWidget code you should have a look in > plasma/private/kineticscroll.* because there is the old kinetic scroll > implementation and it is used by others classes(like plasma/webview) and > would be difficult maintain two d

Re: Review Request: Rewrite kinetic scrolling on ScrollWidget

2010-03-17 Thread Marco Martin
> On 2010-03-17 12:20:55, igorto wrote: > > Instead of change the ScrollWidget code you should have a look in > > plasma/private/kineticscroll.* because there is the old kinetic scroll > > implementation and it is used by others classes(like plasma/webview) and > > would be difficult maintain

Re: Review Request: Rewrite kinetic scrolling on ScrollWidget

2010-03-17 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3312/#review4532 --- just by a quick test, the physics seems to work indeed better, it just

Re: Review Request: Rewrite kinetic scrolling on ScrollWidget

2010-03-17 Thread igorto
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3312/#review4534 --- Instead of change the ScrollWidget code you should have a look in pla

Re: Review Request: Rewrite kinetic scrolling on ScrollWidget

2010-03-16 Thread Zack Rusin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3312/ --- (Updated 2010-03-17 04:59:11.654236) Review request for Plasma. Changes --

Review Request: Rewrite kinetic scrolling on ScrollWidget

2010-03-16 Thread Zack Rusin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3312/ --- Review request for Plasma. Summary --- As previously discussed with this ap