Re: Review Request: Rework layout of widget explorer and activity manager in vertical mode

2012-06-30 Thread Bjoern Balazs
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105329/#review15126 --- Ship it! Ship It! - Bjoern Balazs On June 25, 2012, 12:15 p

Re: Review Request: Rework layout of widget explorer and activity manager in vertical mode

2012-06-26 Thread Mark Gaiser
> On June 23, 2012, 12:56 p.m., Mark Gaiser wrote: > > Just wondering. Do you have blur disabled? Otherwise the widget explorer > > misses that. > > Aurélien Gâteau wrote: > Yes, for some reason blur does not work here. I don't think it is a > problem of the widget explorer. > > Mark Gais

Re: Review Request: Rework layout of widget explorer and activity manager in vertical mode

2012-06-26 Thread Aurélien Gâteau
> On June 23, 2012, 12:56 p.m., Mark Gaiser wrote: > > Just wondering. Do you have blur disabled? Otherwise the widget explorer > > misses that. > > Aurélien Gâteau wrote: > Yes, for some reason blur does not work here. I don't think it is a > problem of the widget explorer. > > Mark Gais

Re: Review Request: Rework layout of widget explorer and activity manager in vertical mode

2012-06-25 Thread Mark Gaiser
> On June 23, 2012, 12:56 p.m., Mark Gaiser wrote: > > Just wondering. Do you have blur disabled? Otherwise the widget explorer > > misses that. > > Aurélien Gâteau wrote: > Yes, for some reason blur does not work here. I don't think it is a > problem of the widget explorer. Just did a li

Re: Review Request: Rework layout of widget explorer and activity manager in vertical mode

2012-06-25 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105329/ --- (Updated June 25, 2012, 12:15 p.m.) Review request for Plasma, KDE Usabili

Re: Review Request: Rework layout of widget explorer and activity manager in vertical mode

2012-06-25 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105329/ --- (Updated June 25, 2012, 12:09 p.m.) Review request for Plasma, KDE Usabili

Re: Review Request: Rework layout of widget explorer and activity manager in vertical mode

2012-06-25 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105329/#review15115 --- Ship it! anyways i think is already a significative improvemen

Re: Review Request: Rework layout of widget explorer and activity manager in vertical mode

2012-06-25 Thread Aurélien Gâteau
> On June 25, 2012, 8:34 a.m., Marco Martin wrote: > > in general the patch looks good... > > i don't like the stretched buttons tough I am not super fan of them either, but if you don't stretch them they look worse IMHO: the view is too thin, so the empty space looks like a layout bug. - Aur

Re: Review Request: Rework layout of widget explorer and activity manager in vertical mode

2012-06-25 Thread Aurélien Gâteau
> On June 25, 2012, 9:32 a.m., Thomas Pfeiffer wrote: > > What do you mean by "Fix cropped list items"? They are still cropped and > > look pretty much the same to me. > > And actually fixing them (e.g. by line-wrapping instead of cropping since > > there usually is enough space for an extra l

Re: Review Request: Rework layout of widget explorer and activity manager in vertical mode

2012-06-25 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105329/#review15104 --- What do you mean by "Fix cropped list items"? They are still cr

Re: Review Request: Rework layout of widget explorer and activity manager in vertical mode

2012-06-25 Thread Bjoern Balazs
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105329/#review15102 --- Screenshot: before-after

Re: Review Request: Rework layout of widget explorer and activity manager in vertical mode

2012-06-25 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105329/#review15101 --- Screenshot: before-after

Re: Review Request: Rework layout of widget explorer and activity manager in vertical mode

2012-06-25 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105329/#review15100 --- in general the patch looks good... i don't like the stretched b

Re: Review Request: Rework layout of widget explorer and activity manager in vertical mode

2012-06-25 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105329/#review15099 --- Screenshot: before-after

Re: Review Request: Rework layout of widget explorer and activity manager in vertical mode

2012-06-25 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105329/ --- (Updated June 25, 2012, 8:23 a.m.) Review request for Plasma, KDE Usabilit

Re: Review Request: Rework layout of widget explorer and activity manager in vertical mode

2012-06-25 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105329/ --- (Updated June 25, 2012, 8:16 a.m.) Review request for Plasma, KDE Usabilit

Re: Review Request: Rework layout of widget explorer and activity manager in vertical mode

2012-06-24 Thread Aurélien Gâteau
> On June 24, 2012, 9:29 p.m., Martin Klapetek wrote: > > Screenshot: before-after > > > > > > For consistency with these buttons in System Settings (and all others > > opening new dialog) this should have "..." at the end, eg. "Get New > > Widgets..." (also

Re: Review Request: Rework layout of widget explorer and activity manager in vertical mode

2012-06-24 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105329/#review15082 --- Screenshot: before-after

Re: Review Request: Rework layout of widget explorer and activity manager in vertical mode

2012-06-24 Thread Aurélien Gâteau
> On June 23, 2012, 12:56 p.m., Mark Gaiser wrote: > > Just wondering. Do you have blur disabled? Otherwise the widget explorer > > misses that. Yes, for some reason blur does not work here. I don't think it is a problem of the widget explorer. - Aurélien --

Re: Review Request: Rework layout of widget explorer and activity manager in vertical mode

2012-06-24 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105329/#review15058 --- Ship it! - David Edmundson On June 22, 2012, 10:04 p.m., Aur

Re: Review Request: Rework layout of widget explorer and activity manager in vertical mode

2012-06-23 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105329/#review15040 --- Just wondering. Do you have blur disabled? Otherwise the widget

Review Request: Rework layout of widget explorer and activity manager in vertical mode

2012-06-22 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105329/ --- Review request for Plasma and Marco Martin. Description --- I made a