Re: Review Request: Remember current desktop when changing activity

2012-03-31 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104261/#review12069 --- This review has been submitted with commit 43b05d53caa0f382dcf

Re: Review Request: Remember current desktop when changing activity

2012-03-31 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104261/#review12068 --- This review has been submitted with commit 6397ef5f8977af0d867

Re: Review Request: Remember current desktop when changing activity

2012-03-29 Thread Ingo Klöcker
> On March 21, 2012, 6:29 p.m., Ivan Čukić wrote: > > Ship It! > > makis marimpis wrote: > please forgive my ignorance, but should i close it as submitted or wait? > :-) You should have committed it with the REVIEW keyword. See http://techbase.kde.org/Policies/SVN_Commit_Policy#Special_ke

Re: Review Request: Remember current desktop when changing activity

2012-03-21 Thread Luca Beltrame
In data mercoledì 21 marzo 2012 18:52:45, makis marimpis ha scritto: > > On March 21, 2012, 6:29 p.m., Ivan Čukić wrote: > > > Ship It! > > please forgive my ignorance, but should i close it as submitted or wait? :-) You can use REVIEW: X (where is the review ID) in the commit message (on

Re: Review Request: Remember current desktop when changing activity

2012-03-21 Thread makis marimpis
> On March 21, 2012, 6:29 p.m., Ivan Čukić wrote: > > Ship It! please forgive my ignorance, but should i close it as submitted or wait? :-) - makis --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.k

Re: Review Request: Remember current desktop when changing activity

2012-03-21 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104261/#review11705 --- Ship it! Ship It! - Ivan Čukić On March 18, 2012, 9:22 a.m.

Re: Review Request: Remember current desktop when changing activity

2012-03-18 Thread makis marimpis
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104261/ --- (Updated March 18, 2012, 9:22 a.m.) Review request for KDE Runtime and Pla

Re: Review Request: Remember current desktop when changing activity

2012-03-18 Thread David Faure
> On March 16, 2012, 12:49 p.m., Ivan Čukić wrote: > > > > makis marimpis wrote: > Hm, i did that in order to restore the desktop ids from a previous run of > kamd (let's say, in case of log out). > > Ivan Čukić wrote: > You misunderstood, I don't mind saving it in the config file, I d

Re: Review Request: Remember current desktop when changing activity

2012-03-17 Thread makis marimpis
> On March 16, 2012, 12:49 p.m., Ivan Čukić wrote: > > > > makis marimpis wrote: > Hm, i did that in order to restore the desktop ids from a previous run of > kamd (let's say, in case of log out). > > Ivan Čukić wrote: > You misunderstood, I don't mind saving it in the config file, I d

Re: Review Request: Remember current desktop when changing activity

2012-03-17 Thread Ivan Čukić
> On March 16, 2012, 12:49 p.m., Ivan Čukić wrote: > > > > makis marimpis wrote: > Hm, i did that in order to restore the desktop ids from a previous run of > kamd (let's say, in case of log out). You misunderstood, I don't mind saving it in the config file, I don't understand the need to

Re: Review Request: Remember current desktop when changing activity

2012-03-16 Thread makis marimpis
> On March 16, 2012, 12:49 p.m., Ivan Čukić wrote: > > Hm, i did that in order to restore the desktop ids from a previous run of kamd (let's say, in case of log out). - makis --- This is an automatically generated e-mail. To reply, vis

Re: Review Request: Remember current desktop when changing activity

2012-03-16 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104261/#review11467 --- service/ActivityManager.cpp

Re: Review Request: Remember current desktop when changing activity

2012-03-16 Thread makis marimpis
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104261/ --- (Updated March 16, 2012, 11:55 a.m.) Review request for KDE Runtime and Pl

Re: Review Request: Remember current desktop when changing activity

2012-03-16 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104261/#review11462 --- generally looks good to me, save for one small issue. service

Re: Review Request: Remember current desktop when changing activity

2012-03-16 Thread makis marimpis
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104261/ --- (Updated March 16, 2012, 7:40 a.m.) Review request for KDE Runtime and Pla