Re: Review Request: Plasma Netbook animated Version 1

2009-10-30 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2008/#review2870 --- Ship it! to me looks good. i think the grid animation there is here s

Re: Review Request: Plasma Netbook animated Version 1

2009-10-29 Thread igorto
> On 2009-10-29 21:23:59, Marco Martin wrote: > > trunk/KDE/kdebase/workspace/plasma/netbook/containments/common/proxylayout.h, > > line 9 > > > > > > QGraphicsLayoutItem should be more than enough done > On 2009-10-29

Re: Review Request: Plasma Netbook animated Version 1

2009-10-29 Thread igorto
> On 2009-10-29 18:45:38, Artur de Souza (MoRpHeUz) wrote: > > The commit itself seems nice. Just worried if we want to start using this > > all around. *Maybe* we have animated layouts in Qt *4.7* that would be more > > generic than this. But if we just want something specific it seems fine fo

Re: Review Request: Plasma Netbook animated Version 1

2009-10-29 Thread igorto
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2008/ --- (Updated 2009-10-30 03:40:42.598111) Review request for Plasma, Aaron Seigo, Mar

Re: Review Request: Plasma Netbook animated Version 1

2009-10-29 Thread Marco Martin
On Thursday 29 October 2009, Artur Souza (MoRpHeUz) wrote: > On Thursday 29 October 2009, 18:23 Marco Martin wrote: > > there seems to be some issues with size hints, since the only way to have > > a proper hint is to have the final size the widget will have seems hard > > to fix, how do you guys d

Re: Review Request: Plasma Netbook animated Version 1

2009-10-29 Thread Artur Souza (MoRpHeUz)
On Thursday 29 October 2009, 18:23 Marco Martin wrote: > there seems to be some issues with size hints, since the only way to have a > proper hint is to have the final size the widget will have seems hard to > fix, how do you guys did with the real qt ones? I need to take a look at our branch. B

Re: Review Request: Plasma Netbook animated Version 1

2009-10-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2008/#review2856 --- i generally like it, apart of the couple of code issues below i think

Re: Review Request: Plasma Netbook animated Version 1

2009-10-29 Thread Marco Martin
> On 2009-10-29 18:45:38, Artur de Souza (MoRpHeUz) wrote: > > The commit itself seems nice. Just worried if we want to start using this > > all around. *Maybe* we have animated layouts in Qt *4.7* that would be more > > generic than this. But if we just want something specific it seems fine fo

Re: Review Request: Plasma Netbook animated Version 1

2009-10-29 Thread igorto
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2008/ --- (Updated 2009-10-29 18:45:58.421256) Review request for Plasma, Aaron Seigo, Mar

Re: Review Request: Plasma Netbook animated Version 1

2009-10-29 Thread Artur de Souza (MoRpHeUz)
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2008/#review2853 --- The commit itself seems nice. Just worried if we want to start using t

Review Request: Plasma Netbook animated Version 1

2009-10-29 Thread igorto
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2008/ --- Review request for Plasma, Aaron Seigo, Marco Martin, Artur de Souza (MoRpHeUz),