> On 2010-10-12 20:19:23, Marco Martin wrote:
> > just looking at the code seems sensible so far, did you tested it
> > extensively? did you find any misbehaviour?
> > (will do it tomorrow anyways)
> > if it appear to behave well i think it could be tried to make it go in
>
> Ingomar Wesp wrot
> On 2010-10-12 20:19:23, Marco Martin wrote:
> > just looking at the code seems sensible so far, did you tested it
> > extensively? did you find any misbehaviour?
> > (will do it tomorrow anyways)
> > if it appear to behave well i think it could be tried to make it go in
> did you tested it e
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5580/#review8102
---
just looking at the code seems sensible so far, did you tested it
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5580/
---
(Updated 2010-10-11 13:06:24.092922)
Review request for Plasma.
Changes
--
> On 2010-10-11 08:34:14, Marco Martin wrote:
> > > The reported preferredSize is not bounded by the maximumSize.
> >
> > you don't have to call maximumSize(), it's the hardcoded overriding size
> > hint that you can set from the outside ith setMaximumSize.
> >
> > you just have to obtain it
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5580/#review8073
---
> The reported preferredSize is not bounded by the maximumSize.
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5580/
---
Review request for Plasma.
Summary
---
I poked around the IconWidget cl