Re: Review Request: Mouse hover effect on ListItem

2012-08-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105939/#review17183 --- This review has been submitted with commit 79be54420991a94d824

Re: Review Request: Mouse hover effect on ListItem

2012-08-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105939/#review17182 --- This review has been submitted with commit 4f375dcb1ce4cf09777

Re: Review Request: Mouse hover effect on ListItem

2012-08-10 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105939/#review17180 --- Ship it! Ship It! - Marco Martin On Aug. 9, 2012, 12:08 a.m

Re: Review Request: Mouse hover effect on ListItem

2012-08-10 Thread Marco Martin
> On Aug. 9, 2012, 3:17 p.m., Marco Martin wrote: > > i think it makes sense, two important things should be assured tough: > > a) on the normal case, with click disabled, the effect muct be disabled as > > well (it disables the mouse area so should work) > > b) now a touch version without effec

Re: Review Request: Mouse hover effect on ListItem

2012-08-09 Thread Aleix Pol Gonzalez
> On Aug. 9, 2012, 3:17 p.m., Marco Martin wrote: > > i think it makes sense, two important things should be assured tough: > > a) on the normal case, with click disabled, the effect muct be disabled as > > well (it disables the mouse area so should work) > > b) now a touch version without effec

Re: Review Request: Mouse hover effect on ListItem

2012-08-09 Thread Marco Martin
> On Aug. 9, 2012, 3:17 p.m., Marco Martin wrote: > > i think it makes sense, two important things should be assured tough: > > a) on the normal case, with click disabled, the effect muct be disabled as > > well (it disables the mouse area so should work) > > b) now a touch version without effec

Re: Review Request: Mouse hover effect on ListItem

2012-08-09 Thread Aleix Pol Gonzalez
> On Aug. 9, 2012, 3:17 p.m., Marco Martin wrote: > > i think it makes sense, two important things should be assured tough: > > a) on the normal case, with click disabled, the effect muct be disabled as > > well (it disables the mouse area so should work) > > b) now a touch version without effec

Re: Review Request: Mouse hover effect on ListItem

2012-08-09 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105939/#review17158 --- i think it makes sense, two important things should be assured

Re: Review Request: Mouse hover effect on ListItem

2012-08-09 Thread Marco Martin
> On Aug. 9, 2012, 2:31 p.m., Aurélien Gâteau wrote: > > I like the idea, but I think it would be less surprising if the opacity > > would actually increase on hover. > > Aleix Pol Gonzalez wrote: > Yes, I know. If everybody agrees I can change that. while makes more semantically sense, i

Re: Review Request: Mouse hover effect on ListItem

2012-08-09 Thread Aleix Pol Gonzalez
> On Aug. 9, 2012, 2:37 p.m., Daker Pinheiro wrote: > > I like this kind of behavior, but I think that more people should aprove it. > > Exporting the containsMouse property as well as the background is another > > solution that doesn't breaks > > existing code. Well, here we're not adding any

Re: Review Request: Mouse hover effect on ListItem

2012-08-09 Thread Aleix Pol Gonzalez
> On Aug. 9, 2012, 2:31 p.m., Aurélien Gâteau wrote: > > I like the idea, but I think it would be less surprising if the opacity > > would actually increase on hover. Yes, I know. If everybody agrees I can change that. - Aleix --- This

Re: Review Request: Mouse hover effect on ListItem

2012-08-09 Thread Daker Pinheiro
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105939/#review17154 --- I like this kind of behavior, but I think that more people shou

Re: Review Request: Mouse hover effect on ListItem

2012-08-09 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105939/#review17153 --- I like the idea, but I think it would be less surprising if the

Review Request: Mouse hover effect on ListItem

2012-08-08 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105939/ --- Review request for Plasma, Marco Martin and Daker Pinheiro. Description --